fixed code review comments. Added more code to check for null values in volume detail page.

sghatty · sghatty · commit cd8fc600804f · 2017-11-17T08:22:39.000-06:00
diff --git a/SoftLayer/CLI/file/detail.py b/SoftLayer/CLI/file/detail.py
@@ -78,11 +78,13 @@ def cli(env, volume_id):
 
     if file_volume['activeTransactions']:
         for trans in file_volume['activeTransactions']:
-            table.add_row([
-                'Ongoing Transactions',
-                trans['transactionStatus']['friendlyName']])
+            if  trans['transactionStatus'] and trans['transactionStatus']['friendlyName']:
+                table.add_row([
+                    'Ongoing Transactions',
+                    trans['transactionStatus']['friendlyName']])
 
-    table.add_row(['Replicant Count', "%u"
+    if file_volume['replicationPartnerCount']:
+        table.add_row(['Replicant Count', "%u"
                    % file_volume['replicationPartnerCount']])
 
     if file_volume['replicationPartnerCount'] > 0:
diff --git a/SoftLayer/CLI/file/modify.py b/SoftLayer/CLI/file/modify.py
@@ -20,8 +20,7 @@
                    'Potential Sizes: [20, 40, 80, 100, 250, '
                    '500, 1000, 2000, 4000, 8000, 12000] '
                    'Minimum: [the size of the origin volume] '
-                   'Maximum: [the minimum of 12000 GB or '
-                   '10*(origin volume size)]')
+                   'Maximum: [the minimum of 12000 GB.')
 @click.option('--new-iops', '-i',
               type=int,
               help='Performance Storage IOPS, between 100 and 6000 in '
