Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: huyha85/opengraph_parser
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: sharethrough/opengraph_parser
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 10 commits
  • 9 files changed
  • 7 contributors

Commits on Sep 17, 2015

  1. Allow redirect_limit override in OpenGraph.new

    @anthonylewis
    anthonylewis committed Sep 17, 2015
    Configuration menu
    Copy the full SHA
    80a99f7 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2015

  1. Extract url first from og:url than src.

    @Nakort
    Nakort committed Oct 6, 2015
    Configuration menu
    Copy the full SHA
    10bfeb9 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2016

  1. Merge branch 'master' of https://github.com/Nakort/opengraph_parser i… 

    …nto mmm/fix_image_url
    @nuclearghost
    nuclearghost committed Jan 18, 2016
    Configuration menu
    Copy the full SHA
    7437343 View commit details
    Browse the repository at this point in the history

  2. Catch bad URI expcetion

    @nuclearghost
    nuclearghost committed Jan 18, 2016
    Configuration menu
    Copy the full SHA
    dd39d45 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2016

  1. Don't set the url to the src if the src is html

    @nuclearghost
    nuclearghost committed Jan 27, 2016
    Configuration menu
    Copy the full SHA
    2b7910e View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2016

  1. Return empty for failed description fallback

    Carlo Cajucom committed Jul 21, 2016
    Configuration menu
    Copy the full SHA
    c197a09 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2016

  1. When parsing, check the given src for being a URI, if not, assume it … 

    …is html

Sometimes html doesn’t include “</html>”. In this case, the parsing
would blow up, even if it could pull image/description other og tags
from the html. Instead of checking for </html>, check for a valid URL
and fallback on parsing the html.
    Michael Thompson committed Dec 7, 2016
    Configuration menu
    Copy the full SHA
    90a0407 View commit details
    Browse the repository at this point in the history

  2. Add spec for scenario where the given source has no closing html tag … 

    …but has parseable og tags
    Michael Thompson committed Dec 7, 2016
    Configuration menu
    Copy the full SHA
    c97b145 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #1 from sharethrough/mt/fix-url-vs-html-check 

    When parsing, check the given src for being a URI
    @mthomps
    mthomps authored Dec 7, 2016
    Configuration menu
    Copy the full SHA
    fd961dd View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. URI.escape is obsolete in ruby v3+ and should be replaced by `URI::DE… 

    …FAULT_PARSER.escape`
    @MenelikTucker-districtm
    MenelikTucker-districtm authored Jan 22, 2024
    Configuration menu
    Copy the full SHA
    08d38fc View commit details
    Browse the repository at this point in the history
Loading