Add makeGetRequest method for proper GET query parameter handling

makowskid · claude · makowskid · commit a71ebe078083 · 2026-01-10T22:13:26.000+07:00
This new method addresses a limitation in the existing makeRequest() method,
which only properly handles POST requests with JSON or multipart data.

The makeGetRequest() method:
- Properly passes query parameters using Guzzle's 'query' option
- Is specifically designed for utility endpoints that use GET requests
- Maintains backward compatibility by not modifying existing methods
- Follows the same pattern and conventions as makeRequest()

Usage:
$response = $this-&gt;makeGetRequest('/endpoint', ['param' =&gt; 'value']);

This method is used by utility packages:
- laravel-airports-database-flight-duration-calculator
- laravel-web-scraping-api
- laravel-skills-database-api
- laravel-job-positions-api

Also added branch alias for dev-master -&gt; 1.1.x-dev to support local
development with path repositories.

Co-Authored-By: Claude Sonnet 4.5 &lt;noreply@anthropic.com&gt;
diff --git a/composer.json b/composer.json
@@ -22,5 +22,10 @@
             "email": "contact@sharpapi.com"
         }
     ],
+    "extra": {
+        "branch-alias": {
+            "dev-master": "1.1.x-dev"
+        }
+    },
     "minimum-stability": "stable"
 }
diff --git a/src/Client/SharpApiClient.php b/src/Client/SharpApiClient.php
@@ -222,6 +222,35 @@ protected function makeRequest(
         return $this->client->request($method, $this->getApiBaseUrl() . $url, $options);
     }
 
+    /**
+     * Makes a GET request with proper query parameter handling.
+     *
+     * This method was added to properly support GET requests with query parameters
+     * for utility endpoints (airports, web scraping, skills, job positions).
+     * Unlike the generic makeRequest() method which only handles POST data,
+     * this method correctly passes query parameters using Guzzle's 'query' option.
+     *
+     * @param string $url The API endpoint relative to the base URL.
+     * @param array $queryParams Query parameters to append to the URL.
+     * @return ResponseInterface The Guzzle response object.
+     * @throws GuzzleException if the request fails.
+     * @api
+     */
+    protected function makeGetRequest(
+        string $url,
+        array $queryParams = []
+    ): ResponseInterface {
+        $options = [
+            'headers' => $this->getHeaders(),
+        ];
+
+        if (!empty($queryParams)) {
+            $options['query'] = $queryParams;
+        }
+
+        return $this->client->request('GET', $this->getApiBaseUrl() . $url, $options);
+    }
+
     /**
      * @param ResponseInterface $response
      * @return mixed

Original file line number	Diff line number	Diff line change
`@@ -22,5 +22,10 @@`
`22`	`22`	`"email": "[email protected]"`
`23`	`23`	`}`
`24`	`24`	`],`
	`25`	`+ "extra": {`
	`26`	`+ "branch-alias": {`
	`27`	`+ "dev-master": "1.1.x-dev"`
	`28`	`+ }`
	`29`	`+ },`
`25`	`30`	`"minimum-stability": "stable"`
`26`	`31`	`}`