If the proxy is unset then you cannot set http_proxy in the environment

Ashley Penney · Ashley Penney · commit 11666f9b9ebf · 2012-10-17T20:31:43.000Z
or it breaks pip completely and the virtualenv fails.
diff --git a/manifests/virtualenv.pp b/manifests/virtualenv.pp
@@ -50,9 +50,14 @@
       default  => "--proxy=${proxy}",
     }
 
+    $proxy_command = $proxy ? {
+      false   => '',
+      default => "&& export http_proxy=${proxy}",
+    }
+
     exec { "python_virtualenv_${venv_dir}":
       command => "mkdir -p ${venv_dir} \
-        && export http_proxy=${proxy} \
+        ${proxy_command} \
         && virtualenv -p `which ${python}` ${venv_dir} \
         && ${venv_dir}/bin/pip install ${proxy_flag} --upgrade distribute pip",
       creates => $venv_dir,
