Allow virtualenv definitions to share the same requirements file

Nick Groenen · Nick Groenen · commit 88c178043145 · 2013-03-11T15:18:24.000+01:00
diff --git a/manifests/requirements.pp b/manifests/requirements.pp
@@ -4,6 +4,9 @@
 #
 # === Parameters
 #
+# [*requirements*]
+#  Path to the requirements file. Defaults to the resource name
+#
 # [*virtualenv*]
 #  virtualenv to run pip in. Default: system-wide
 #
@@ -23,12 +26,11 @@
 # Ashley Penney
 #
 define python::requirements (
-  $virtualenv = 'system',
-  $proxy      = false
+  $requirements = $name,
+  $virtualenv   = 'system',
+  $proxy        = false
 ) {
 
-  $requirements = $name
-
   $pip_env = $virtualenv ? {
     'system' => '`which pip`',
     default  => "${virtualenv}/bin/pip",
@@ -41,13 +43,17 @@
 
   $req_crc = "${requirements}.sha1"
 
-  file { $requirements:
-    ensure  => present,
-    mode    => '0644',
-    owner   => 'root',
-    group   => 'root',
-    replace => false,
-    content => '# Puppet will install and/or update pip packages listed here',
+   # This will ensure multiple python::virtualenv definitions can share the
+   # the same requirements file.
+   if !defined(File[$requirements]) {
+	file { $requirements:
+      ensure  => present,
+      mode    => '0644',
+      owner   => 'root',
+      group   => 'root',
+      replace => false,
+      content => '# Puppet will install and/or update pip packages listed here',
+    }
   }
 
   # SHA1 checksum to detect changes
diff --git a/manifests/virtualenv.pp b/manifests/virtualenv.pp
@@ -76,17 +76,18 @@
     }
 
     if $requirements {
-      exec { "python_requirements_initial_install_${requirements}":
+      exec { "python_requirements_initial_install_${requirements}_${venv_dir}":
         command     => "${venv_dir}/bin/pip install ${proxy_flag} --requirement ${requirements}",
         refreshonly => true,
         timeout     => 1800,
         subscribe   => Exec["python_virtualenv_${venv_dir}"],
       }
 
-      python::requirements { $requirements:
-        virtualenv => $venv_dir,
-        proxy      => $proxy,
-        require    => Exec["python_virtualenv_${venv_dir}"],
+      python::requirements { "${requirements}_${venv_dir}":
+        requirements => $requirements,
+        virtualenv   => $venv_dir,
+        proxy        => $proxy,
+        require      => Exec["python_virtualenv_${venv_dir}"],
       }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -76,17 +76,18 @@`
`76`	`76`	`}`
`77`	`77`
`78`	`78`	`if $requirements {`
`79`		`- exec { "python_requirements_initial_install_${requirements}":`
	`79`	`+ exec { "python_requirements_initial_install_${requirements}_${venv_dir}":`
`80`	`80`	`command => "${venv_dir}/bin/pip install ${proxy_flag} --requirement ${requirements}",`
`81`	`81`	`refreshonly => true,`
`82`	`82`	`timeout => 1800,`
`83`	`83`	`subscribe => Exec["python_virtualenv_${venv_dir}"],`
`84`	`84`	`}`
`85`	`85`
`86`		`- python::requirements { $requirements:`
`87`		`- virtualenv => $venv_dir,`
`88`		`- proxy => $proxy,`
`89`		`- require => Exec["python_virtualenv_${venv_dir}"],`
	`86`	`+ python::requirements { "${requirements}_${venv_dir}":`
	`87`	`+ requirements => $requirements,`
	`88`	`+ virtualenv => $venv_dir,`
	`89`	`+ proxy => $proxy,`
	`90`	`+ require => Exec["python_virtualenv_${venv_dir}"],`
`90`	`91`	`}`
`91`	`92`	`}`
`92`	`93`