Merged
Conversation
Contributor
|
@frievoe97 I notice is that the tooltip doesn't update when clicking on a second link. I think the click method might need to clear the highlighted link before it sets/selects the next link. For Vue to update that correctly you might need an That would probably also fix the other bug I notice which is that clicking away / clearing the selected link doesnt hide the tooltip until the user moves the mouse. But in general this is very close to working! |
Collaborator
Author
|
There are two merge conflicts and I don't want to break anything. Can you check that? @billyc |
…dates when clicking on an other link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea is to display a fixed tooltip after clicking on a link. Once a link is selected, it stays highlighted even if the mouse moves away, making it clear which link is currently selected. To "unfix" the tooltip, you can either click on another link or click in an empty area.
However, the implementation is a bit buggy. It takes a few milliseconds for the effect to take place after the onClick method is called.
@billyc Could you take a look and give me some feedback?