-
Notifications
You must be signed in to change notification settings - Fork 23
Vehicle-animation bugs from Marcel #48
Copy link
Copy link
Closed
Labels
Description
From Marcel's 2021-07 emails.
- Small lines next to vehicles because the icon-atlas is a bit off. The line is made up of small dots that move along with the vehicles (btw something I also noticed in your avoev visualizations). This is due to the point of the marker in the icon-atlas.png coming further down than just the expected 128px. If I change the the definition of the vehicle in the ICON_MAPPING to vehicle: {x: 128, y: 132, width: 128, height: 124, mask: true}, (note the y:132, height:124 instead of 128 each), this disappears. So it can be easily fixed by choosing or designing the icons accordingly.
- I do not yet filter my data, just pass every vehicle on every link at once inside the
pathsdata structure. Then, when a vehicle is moving from one link to the next, it is actually drawn twice, once on the "old" link, once on the "new" one, as can be seen below at the vertex. It can be easily fixed by filtering the data provided to the layer (which might be a good thing anyway), but maybe it would also make sense to define the lower time boundary (i.e. t0) to be inclusive, bu the upper time boundary (t1) to be exclusive. Just a thought, nothing that needs to be fixed from my point of view, just something I noticed.
- Highlighting a vehicle. When a vehicle is clicked, I use
this.vehiclesLayer.highlightedObjectIndex = object.indexto highlight the vehicle. But while the regular vehicles appear smooth, the highlighted one looks not-anti-aliased. I don't know it this is something that you can control, or if that comes from the underlying IconLayer. In any case, it is a very minor issue.
- Resizing the view. When I resize my browser window so that the visualization area get's smaller, the layer itself seems not to resize. It then paints across other things and is no longer correctly aligned. I does not seem to happen in the aftersim-visualizations that I checked. So I don't not yet where the problem is, and I just discovered it very recently. Did you experience similar behavior? I will try to look into this issue more. I would have expected that deck.gl informs the layer about a change in the viewport size to adapt, but really I don't know.
Reactions are currently unavailable



