Modify end time of lambda load span to be last cold start node's end_time (DataDog#319)

joeyzhao2018 · web-flow · commit 12b2c8bf6fee · 2023-04-12T14:14:36.000-04:00
* modify endtime of lambda load span to be the last cold start node endtime
diff --git a/datadog_lambda/cold_start.py b/datadog_lambda/cold_start.py
@@ -134,14 +134,16 @@ def __init__(
         self,
         tracer,
         function_name,
-        cold_start_span_finish_time_ns,
+        current_span_start_time_ns,
         trace_ctx,
         min_duration_ms: int,
-        ignored_libs: List[str] = [],
+        ignored_libs: List[str] = None,
     ):
+        if ignored_libs is None:
+            ignored_libs = []
         self._tracer = tracer
         self.function_name = function_name
-        self.cold_start_span_finish_time_ns = cold_start_span_finish_time_ns
+        self.current_span_start_time_ns = current_span_start_time_ns
         self.min_duration_ms = min_duration_ms
         self.trace_ctx = trace_ctx
         self.ignored_libs = ignored_libs
@@ -151,11 +153,14 @@ def trace(self, root_nodes: List[ImportNode] = root_nodes):
         if not root_nodes:
             return
         cold_start_span_start_time_ns = root_nodes[0].start_time_ns
+        cold_start_span_end_time_ns = min(
+            root_nodes[-1].end_time_ns, self.current_span_start_time_ns
+        )
         cold_start_span = self.create_cold_start_span(cold_start_span_start_time_ns)
         while root_nodes:
             root_node = root_nodes.pop()
             self.trace_tree(root_node, cold_start_span)
-        self.finish_span(cold_start_span, self.cold_start_span_finish_time_ns)
+        self.finish_span(cold_start_span, cold_start_span_end_time_ns)
 
     def trace_tree(self, import_node: ImportNode, parent_span):
         if (
diff --git a/datadog_lambda/tracing.py b/datadog_lambda/tracing.py
@@ -385,7 +385,7 @@ def is_authorizer_response(response) -> bool:
             and response["principalId"]
             and response["policyDocument"]
         )
-    except KeyError:
+    except (KeyError, AttributeError):
         pass
     except Exception as e:
         logger.debug("unknown error while checking is_authorizer_response %s", e)
diff --git a/scripts/build_layers.sh b/scripts/build_layers.sh
@@ -68,7 +68,7 @@ mkdir $LAYER_DIR
 
 for python_version in "${PYTHON_VERSIONS[@]}"
 do
-    if [ "$python_version" == "3.8" ] || [ "$python_version" == "3.9" ]; then
+    if [ "$python_version" != "3.7" ]; then
         echo "Building layer for Python ${python_version} arch=arm64"
         docker_build_zip ${python_version} $LAYER_DIR/${LAYER_FILES_PREFIX}-arm64-${python_version}.zip arm64
     fi

Original file line number	Diff line number	Diff line change
`@@ -385,7 +385,7 @@ def is_authorizer_response(response) -> bool:`
`385`	`385`	`and response["principalId"]`
`386`	`386`	`and response["policyDocument"]`
`387`	`387`	`)`
`388`		`- except KeyError:`
	`388`	`+ except (KeyError, AttributeError):`
`389`	`389`	`pass`
`390`	`390`	`except Exception as e:`
`391`	`391`	`logger.debug("unknown error while checking is_authorizer_response %s", e)`