-
Notifications
You must be signed in to change notification settings - Fork 53
Description
This is very annoying - while the m135 release notes says "SkPDF::MakeDocument(SkWStream*)" is deprecated, what actually happens is that it changes behavior - it used to run correctly but now it compiles and builds successfully, then it throws an error at runtime. (Ie. At pytest).
I would rather they just remove it, or keep it working, instead of shipping an intentionally broken API in m135.
WIP in my hard disk. So this is delaying a m135-public, although not releasing until m136...
The specific part of release note below:
SkPDF::MakeDocument(SkWStream*) [one argument] has been deprecated and will be removed. This is because SkPDFMetdata has added 2 required fields jpegDecoder and jpegEncoder. In order to make a reasonable PDF, those must be supplied (using the two argument factory). To make these easier to supply include/docs/SkPDFJpegHelpers.h has been added, which will use Skia's built-in jpeg encoder and decoder.