Skip to content

Commit 967380d

Browse files
author
Gavin Williams
committed
Address final Coderabbit comments
1 parent ca8ace9 commit 967380d

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

packages/web/src/features/agents/review-agent/nodes/gitlabMrParser.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ export const gitlabMrParser = async (
9797
repo: repoName,
9898
file_diffs: filteredSourcebotFileDiffs,
9999
number: mrIid,
100-
head_sha: mr.sha ?? "",
100+
head_sha: mr.sha ?? mrPayload.object_attributes.last_commit.id,
101101
diff_refs: mr.diff_refs != null
102102
? mr.diff_refs as { base_sha: string; head_sha: string; start_sha: string }
103103
: undefined,

packages/web/src/features/agents/review-agent/types.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ const gitLabDiffRefsSchema = z.object({
7171
}).nullable().optional();
7272

7373
export const gitLabMergeRequestPayloadSchema = z.object({
74-
object_kind: z.string(),
74+
object_kind: z.literal('merge_request'),
7575
object_attributes: z.object({
7676
iid: z.number(),
7777
title: z.string(),
@@ -85,10 +85,10 @@ export const gitLabMergeRequestPayloadSchema = z.object({
8585
export type GitLabMergeRequestPayload = z.infer<typeof gitLabMergeRequestPayloadSchema>;
8686

8787
export const gitLabNotePayloadSchema = z.object({
88-
object_kind: z.string(),
88+
object_kind: z.literal('note'),
8989
object_attributes: z.object({
9090
note: z.string(),
91-
noteable_type: z.string(),
91+
noteable_type: z.literal('MergeRequest'),
9292
}),
9393
merge_request: z.object({
9494
iid: z.number(),

0 commit comments

Comments
 (0)