Skip to content

Commit 9bf15ce

Browse files
Consolidate goto ref / def posthog events into single event with a source. Added posthog event and audit log for goto/find all refs for chat
1 parent cb6c6cb commit 9bf15ce

File tree

4 files changed

+45
-12
lines changed

4 files changed

+45
-12
lines changed

packages/web/src/app/[domain]/browse/[...path]/components/pureCodePreviewPanel.tsx

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,9 @@ export const PureCodePreviewPanel = ({
136136
}, [editorRef, highlightRange]);
137137

138138
const onFindReferences = useCallback((symbolName: string) => {
139-
captureEvent('wa_browse_find_references_pressed', {});
139+
captureEvent('wa_find_references_pressed', {
140+
source: 'browse',
141+
});
140142
createAuditAction({
141143
action: "user.performed_find_references",
142144
metadata: {
@@ -160,7 +162,9 @@ export const PureCodePreviewPanel = ({
160162
// If we resolve multiple matches, instead of navigating to the first match, we should
161163
// instead popup the bottom sheet with the list of matches.
162164
const onGotoDefinition = useCallback((symbolName: string, symbolDefinitions: SymbolDefinition[]) => {
163-
captureEvent('wa_browse_goto_definition_pressed', {});
165+
captureEvent('wa_goto_definition_pressed', {
166+
source: 'browse',
167+
});
164168
createAuditAction({
165169
action: "user.performed_goto_definition",
166170
metadata: {

packages/web/src/app/[domain]/search/components/codePreviewPanel/codePreview.tsx

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,9 @@ export const CodePreview = ({
119119
}, [onSelectedMatchIndexChange]);
120120

121121
const onGotoDefinition = useCallback((symbolName: string, symbolDefinitions: SymbolDefinition[]) => {
122-
captureEvent('wa_preview_panel_goto_definition_pressed', {});
122+
captureEvent('wa_goto_definition_pressed', {
123+
source: 'preview',
124+
});
123125
createAuditAction({
124126
action: "user.performed_goto_definition",
125127
metadata: {
@@ -163,7 +165,9 @@ export const CodePreview = ({
163165
}, [captureEvent, file.filepath, file.language, file.revision, navigateToPath, repoName, domain]);
164166

165167
const onFindReferences = useCallback((symbolName: string) => {
166-
captureEvent('wa_preview_panel_find_references_pressed', {});
168+
captureEvent('wa_find_references_pressed', {
169+
source: 'preview',
170+
});
167171
createAuditAction({
168172
action: "user.performed_find_references",
169173
metadata: {

packages/web/src/features/chat/components/chatThread/referencedFileSourceListItem.tsx

Lines changed: 27 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,9 @@ import { ChevronDown, ChevronRight } from "lucide-react";
1717
import { forwardRef, Ref, useCallback, useImperativeHandle, useMemo, useState } from "react";
1818
import { FileReference } from "../../types";
1919
import { createCodeFoldingExtension } from "./codeFoldingExtension";
20-
20+
import useCaptureEvent from "@/hooks/useCaptureEvent";
21+
import { createAuditAction } from "@/ee/features/audit/actions";
22+
import { useDomain } from "@/hooks/useDomain";
2123

2224
const lineDecoration = Decoration.line({
2325
attributes: { class: "cm-range-border-radius chat-lineHighlight" },
@@ -69,6 +71,8 @@ const ReferencedFileSourceListItem = ({
6971
}: ReferencedFileSourceListItemProps, forwardedRef: Ref<ReactCodeMirrorRef>) => {
7072
const theme = useCodeMirrorTheme();
7173
const [editorRef, setEditorRef] = useState<ReactCodeMirrorRef | null>(null);
74+
const captureEvent = useCaptureEvent();
75+
const domain = useDomain();
7276

7377
useImperativeHandle(
7478
forwardedRef,
@@ -216,6 +220,16 @@ const ReferencedFileSourceListItem = ({
216220
return;
217221
}
218222

223+
captureEvent('wa_goto_definition_pressed', {
224+
source: 'chat',
225+
});
226+
createAuditAction({
227+
action: "user.performed_goto_definition",
228+
metadata: {
229+
message: symbolName,
230+
},
231+
}, domain);
232+
219233
if (symbolDefinitions.length === 1) {
220234
const symbolDefinition = symbolDefinitions[0];
221235
const { fileName, repoName } = symbolDefinition;
@@ -246,9 +260,19 @@ const ReferencedFileSourceListItem = ({
246260
});
247261

248262
}
249-
}, [navigateToPath, revision, repoName, fileName, language]);
263+
}, [captureEvent, domain, navigateToPath, revision, repoName, fileName, language]);
250264

251265
const onFindReferences = useCallback((symbolName: string) => {
266+
captureEvent('wa_find_references_pressed', {
267+
source: 'chat',
268+
});
269+
createAuditAction({
270+
action: "user.performed_find_references",
271+
metadata: {
272+
message: symbolName,
273+
},
274+
}, domain);
275+
252276
navigateToPath({
253277
repoName,
254278
revisionName: revision,
@@ -266,7 +290,7 @@ const ReferencedFileSourceListItem = ({
266290
}
267291
})
268292

269-
}, [fileName, language, navigateToPath, repoName, revision]);
293+
}, [captureEvent, domain, fileName, language, navigateToPath, repoName, revision]);
270294

271295
const ExpandCollapseIcon = useMemo(() => {
272296
return isExpanded ? ChevronDown : ChevronRight;

packages/web/src/lib/posthogEvents.ts

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -268,11 +268,12 @@ export type PosthogEventMap = {
268268
wa_api_key_created: {},
269269
wa_api_key_creation_fail: {},
270270
//////////////////////////////////////////////////////////////////
271-
wa_preview_panel_find_references_pressed: {},
272-
wa_preview_panel_goto_definition_pressed: {},
273-
//////////////////////////////////////////////////////////////////
274-
wa_browse_find_references_pressed: {},
275-
wa_browse_goto_definition_pressed: {},
271+
wa_goto_definition_pressed: {
272+
source: 'chat' | 'browse' | 'preview',
273+
},
274+
wa_find_references_pressed: {
275+
source: 'chat' | 'browse' | 'preview',
276+
},
276277
//////////////////////////////////////////////////////////////////
277278
wa_explore_menu_reference_clicked: {},
278279
//////////////////////////////////////////////////////////////////

0 commit comments

Comments
 (0)