From bd8f96cfa5ad28a3397918516e9c455a6a601ab9 Mon Sep 17 00:00:00 2001 From: Matias Melograno Date: Thu, 11 Oct 2018 17:15:00 -0300 Subject: [PATCH] added input sanitization for get_treatments method --- splitio/clients.py | 4 ++-- splitio/tests/test_input_validator.py | 6 +++--- splitio/version.py | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/splitio/clients.py b/splitio/clients.py index 36d7a120..5d827aa4 100644 --- a/splitio/clients.py +++ b/splitio/clients.py @@ -167,12 +167,12 @@ def get_treatments(self, key, features, attributes=None): :rtype: dict """ if self._destroyed: - return CONTROL + return None features = input_validator.validate_features_get_treatments(features) if features is None: - return CONTROL + return None return {feature: self.get_treatment(key, feature, attributes) for feature in features} diff --git a/splitio/tests/test_input_validator.py b/splitio/tests/test_input_validator.py index 2c32b4c2..e08a8eb6 100644 --- a/splitio/tests/test_input_validator.py +++ b/splitio/tests/test_input_validator.py @@ -459,17 +459,17 @@ def setUp(self): self.logger_warning = input_validator._LOGGER.warning def test_get_treatments_with_null_features(self): - self.assertEqual("control", self.client.get_treatments("some_key", None)) + self.assertEqual(None, self.client.get_treatments("some_key", None)) self.logger_error \ .assert_called_once_with("get_treatments: features cannot be None.") def test_get_treatments_with_bool_type_of_features(self): - self.assertEqual("control", self.client.get_treatments("some_key", True)) + self.assertEqual(None, self.client.get_treatments("some_key", True)) self.logger_error \ .assert_called_once_with("get_treatments: features must be a list.") def test_get_treatments_with_string_type_of_features(self): - self.assertEqual("control", self.client.get_treatments("some_key", "some_string")) + self.assertEqual(None, self.client.get_treatments("some_key", "some_string")) self.logger_error \ .assert_called_once_with("get_treatments: features must be a list.") diff --git a/splitio/version.py b/splitio/version.py index e7c2779a..c5099442 100644 --- a/splitio/version.py +++ b/splitio/version.py @@ -1 +1 @@ -__version__ = '6.2.0' +__version__ = '6.2.0-rc1'