core/doc: make sure name is usable as slug.

kaos · Thibaut · commit b36f3f8095e2 · 2017-03-04T10:50:10.000-05:00
diff --git a/lib/docs/core/doc.rb b/lib/docs/core/doc.rb
@@ -48,7 +48,10 @@ def name
       end
 
       def slug
-        slug = @slug || name.try(:downcase)
+        slug = @slug || (
+          raise "Slug must be set explicitly when name (#{name}) consists of anything else than [\\w\\.%]" if /[^\w\.%]/ =~ name
+          name.try(:downcase)
+        )
         version? ? "#{slug}~#{version_slug}" : slug
       end
 
diff --git a/test/lib/docs/core/doc_test.rb b/test/lib/docs/core/doc_test.rb
@@ -55,6 +55,18 @@ class DocsDocTest < MiniTest::Spec
       doc.version = '42'
       assert_equal 'foo~42', doc.slug
     end
+
+    it "returns 'foobar' when #name has been set to 'FooBar'" do
+      doc.name = 'FooBar'
+      assert_equal 'foobar', doc.slug
+    end
+
+    it "raises error when #name has unsluggable characters" do
+      assert_raises do
+        doc.name = 'Foo-Bar'
+        doc.slug
+      end
+    end
   end
 
   describe ".slug=" do
