Decode "~" in url path

Thibaut · Thibaut · commit d0802988f1f3 · 2016-06-12T17:58:59.000-04:00
diff --git a/lib/app.rb b/lib/app.rb
@@ -287,7 +287,8 @@ def supports_js_redirection?
     'angular~1.2' => 'angularjs~1.2'
   }
 
-  get %r{\A/([\w~\.]+)(\-[\w\-]+)?(/.*)?\z} do |doc, type, rest|
+  get %r{\A/([\w~\.%]+)(\-[\w\-]+)?(/.*)?\z} do |doc, type, rest|
+    doc.sub! '%7E', '~'
     return redirect "/#{DOC_REDIRECTS[doc]}#{type}#{rest}" if DOC_REDIRECTS.key?(doc)
     return redirect "/angularjs/api#{rest}", 301 if doc == 'angular' && rest.start_with?('/ng')
     return 404 unless @doc = find_doc(doc)
diff --git a/test/app_test.rb b/test/app_test.rb
@@ -164,6 +164,14 @@ def app
       assert last_response.not_found?
     end
 
+    it "decodes '~' properly" do
+      get '/html%7E5/'
+      assert last_response.ok?
+
+      get '/html%7E42/'
+      assert last_response.not_found?
+    end
+
     it "redirects with trailing slash" do
       get '/html'
       assert last_response.redirect?

Original file line number	Diff line number	Diff line change
`@@ -287,7 +287,8 @@ def supports_js_redirection?`
`287`	`287`	`'angular~1.2' => 'angularjs~1.2'`
`288`	`288`	`}`
`289`	`289`
`290`		`- get %r{\A/([\w~\.]+)(\-[\w\-]+)?(/.*)?\z} do \|doc, type, rest\|`
	`290`	`+ get %r{\A/([\w~\.%]+)(\-[\w\-]+)?(/.*)?\z} do \|doc, type, rest\|`
	`291`	`+ doc.sub! '%7E', '~'`
`291`	`292`	`return redirect "/#{DOC_REDIRECTS[doc]}#{type}#{rest}" if DOC_REDIRECTS.key?(doc)`
`292`	`293`	`return redirect "/angularjs/api#{rest}", 301 if doc == 'angular' && rest.start_with?('/ng')`
`293`	`294`	`return 404 unless @doc = find_doc(doc)`