fix filename test and prefix utils to browseURL

cpsievert · cpsievert · commit eda4b2d5c4ba · 2015-11-17T21:40:11.000+11:00
diff --git a/NAMESPACE b/NAMESPACE
@@ -44,6 +44,7 @@ importFrom(plyr,ddply)
 importFrom(plyr,join)
 importFrom(plyr,summarise)
 importFrom(stats,setNames)
+importFrom(utils,browseURL)
 importFrom(utils,data)
 importFrom(utils,getFromNamespace)
 importFrom(utils,modifyList)
diff --git a/R/print.R b/R/print.R
@@ -53,7 +53,7 @@ toWidget <- function(x) {
 #' @param ... additional arguments (currently ignored)
 #' @export
 print.figure <- function(x, ...) {
-  browseURL(x$url)
+  utils::browseURL(x$url)
 }
 
 #' Embed a plotly figure as an iframe in a knitr doc
diff --git a/R/utils.R b/R/utils.R
@@ -1,5 +1,5 @@
 #' @importFrom grDevices col2rgb
-#' @importFrom utils getFromNamespace modifyList data packageVersion
+#' @importFrom utils getFromNamespace modifyList data packageVersion browseURL
 #' @importFrom stats setNames
 
 is.plotly <- function(x) inherits(x, "plotly")
diff --git a/tests/testthat/test-plotly-filename.R b/tests/testthat/test-plotly-filename.R
@@ -2,6 +2,7 @@ context("Filename")
 
 test_that("filepath with directories is returned as passed", {
   skip_on_cran()
-  p <- plot_ly(mtcars, x = wt, y = vs, filename = "directory/awesome")
-  expect_match(plotly_POST(p)$filename, "directory/awesome")
+  p <- plot_ly(mtcars, x = wt, y = vs)
+  f <- plotly_POST(p, filename = "directory/awesome")
+  expect_match(f$filename, "directory/awesome")
 })

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ toWidget <- function(x) {`
`53`	`53`	`#' @param ... additional arguments (currently ignored)`
`54`	`54`	`#' @export`
`55`	`55`	`print.figure <- function(x, ...) {`
`56`		`- browseURL(x$url)`
	`56`	`+ utils::browseURL(x$url)`
`57`	`57`	`}`
`58`	`58`
`59`	`59`	`#' Embed a plotly figure as an iframe in a knitr doc`