Add new line when updating key with "set_key" (Alternative to PR#103) (theskumar#123)

Alexander Baker · theskumar · commit ea0604d60917 · 2018-08-09T17:09:24.000+05:30
* added new line when updating value for a key

* updated tests for test_set_key

* updated tests to ignore whitespace at beginning and end of file
diff --git a/dotenv/main.py b/dotenv/main.py
@@ -143,7 +143,7 @@ def set_key(dotenv_path, key_to_set, value_to_set, quote_mode="always"):
         k, v = parse_line(line)
         if k == key_to_set:
             replaced = True
-            line = line_out
+            line = "{}\n".format(line_out)
         print(line, end='')
 
     if not replaced:
diff --git a/tests/test_cli.py b/tests/test_cli.py
@@ -24,13 +24,19 @@ def test_get_key():
 
 
 def test_set_key(dotenv_file):
-    success, key_to_set, value_to_set = dotenv.set_key(dotenv_path, 'HELLO', 'WORLD')
-    success, key_to_set, value_to_set = dotenv.set_key(dotenv_path, 'foo', 'bar')
-    dotenv.get_key(dotenv_path, 'HELLO') == 'WORLD'
+    success, key_to_set, value_to_set = dotenv.set_key(dotenv_file, 'HELLO', 'WORLD')
+    success, key_to_set, value_to_set = dotenv.set_key(dotenv_file, 'foo', 'bar')
+    assert dotenv.get_key(dotenv_file, 'HELLO') == 'WORLD'
+
+    with open(dotenv_file, 'r') as fp:
+        assert 'HELLO="WORLD"\nfoo="bar"' == fp.read().strip()
+
+    success, key_to_set, value_to_set = dotenv.set_key(dotenv_file, 'HELLO', 'WORLD 2')
+    assert dotenv.get_key(dotenv_file, 'HELLO') == 'WORLD 2'
+    assert dotenv.get_key(dotenv_file, 'foo') == 'bar'
 
-    success, key_to_set, value_to_set = dotenv.set_key(dotenv_path, 'HELLO', 'WORLD 2')
-    dotenv.get_key(dotenv_path, 'HELLO') == 'WORLD 2'
-    dotenv.get_key(dotenv_path, 'foo') == 'bar'
+    with open(dotenv_file, 'r') as fp:
+        assert 'HELLO="WORLD 2"\nfoo="bar"' == fp.read().strip()
 
 
 def test_list(cli, dotenv_file):
