🚸 Mark login field as required#1166
Merged
alejsdev merged 2 commits intofastapi:masterfrom Apr 12, 2024
Merged
Conversation
patrick91
commented
Apr 10, 2024
Comment on lines
+46
to
+47
| if (Array.isArray(errDetail)) { | ||
| errDetail = "Something went wrong" |
Contributor
Author
There was a problem hiding this comment.
This is usually when getting a pydantic validation error.
It would be nice to make the error to each field, but it's not straightforward 😊
alejsdev
approved these changes
Apr 12, 2024
gusevyaroslove
pushed a commit
to gusevyaroslove/fastapi-template
that referenced
this pull request
Aug 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR marks email and password as required, so we don't send
the form if they are empty.
It also checks if errors returned by the server are a list, and, if so,
we show a generic error message.