Skip to content

✨ Add new pages, components, panels, modals, and theme; refactor and improvements in existing components#593

Merged
tiangolo merged 14 commits intofastapi:masterfrom
alejsdev:main
Feb 12, 2024
Merged

✨ Add new pages, components, panels, modals, and theme; refactor and improvements in existing components#593
tiangolo merged 14 commits intofastapi:masterfrom
alejsdev:main

Conversation

@alejsdev
Copy link
Copy Markdown
Member

✨ Add new pages, components, panels, modals, and theme; refactor existing components

Comment thread src/new-frontend/src/components/SidebarItems.tsx
Comment thread src/new-frontend/src/pages/auth/Login.tsx Outdated
Comment thread src/new-frontend/src/pages/main/Items.tsx Outdated
title: 'Success!',
description: 'User created successfully.',
status: 'success',
duration: 9000,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
duration: 9000,
duration: 5000,

title: 'Something went wrong.',
description: 'Failed to create user. Please try again.',
status: 'error',
duration: 9000,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
duration: 9000,
duration: 5000,

Comment thread src/new-frontend/src/pages/panels/Appearance.tsx Outdated
Copy link
Copy Markdown
Member

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀

@tiangolo tiangolo added the feature New feature or request label Feb 12, 2024
@tiangolo tiangolo merged commit b4a1da9 into fastapi:master Feb 12, 2024
@alejsdev alejsdev deleted the main branch February 16, 2024 17:46
gusevyaroslove pushed a commit to gusevyaroslove/fastapi-template that referenced this pull request Aug 4, 2024
…improvements in existing components (fastapi#593)

Co-authored-by: Sebastián Ramírez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants