Change notification to remove permit.

piotrmurach · piotrmurach · commit ec03e8c16bae · 2015-12-20T17:01:35.000+01:00
diff --git a/lib/github_api/client/activity/notifications.rb b/lib/github_api/client/activity/notifications.rb
@@ -35,21 +35,19 @@ class Client::Activity::Notifications < API
     #
     # @api public
     def list(*args)
-      arguments(args) do
-        permit %w[ all participating since user repo]
-      end
+      arguments(args)
       params = arguments.params
 
-      response = if ( (user_name = params.delete("user")) &&
-                      (repo_name = params.delete("repo")) )
+      response = if ( (user_name = params.delete('user')) &&
+                      (repo_name = params.delete('repo')) )
         get_request("/repos/#{user_name}/#{repo_name}/notifications", params)
       else
-        get_request("/notifications", params)
+        get_request('/notifications', params)
       end
       return response unless block_given?
       response.each { |el| yield el }
     end
-    alias :all :list
+    alias_method :all, :list
 
     # View a single thread
     #
@@ -62,13 +60,13 @@ def list(*args)
     #
     # @api public
     def get(*args)
-      arguments(args, required: [:id])
+      arguments(args, required: [:thread_id])
 
-      response = get_request("/notifications/threads/#{arguments.id}", arguments.params)
+      response = get_request("/notifications/threads/#{arguments.thread_id}", arguments.params)
       return response unless block_given?
       response.each { |el| yield el }
     end
-    alias :find :get
+    alias_method :find, :get
 
     # Mark as read
     #
@@ -103,19 +101,17 @@ def get(*args)
     #
     # @api public
     def mark(*args)
-      arguments(args) do
-        permit %w[ unread read last_read_at user repo id]
-      end
+      arguments(args)
       params = arguments.params
 
-      if ( (user_name = params.delete("user")) &&
-           (repo_name = params.delete("repo")) )
+      if ( (user_name = params.delete('user')) &&
+           (repo_name = params.delete('repo')) )
 
         put_request("/repos/#{user_name}/#{repo_name}/notifications", params)
       elsif (thread_id = params.delete("id"))
         patch_request("/notifications/threads/#{thread_id}", params)
       else
-        put_request("/notifications", params)
+        put_request('/notifications', params)
       end
     end
 
@@ -132,9 +128,9 @@ def mark(*args)
     #
     # @api public
     def subscribed?(*args)
-      arguments(args, required: [:id])
+      arguments(args, required: [:thread_id])
 
-      get_request("/notifications/threads/#{arguments.id}/subscription", arguments.params)
+      get_request("/notifications/threads/#{arguments.thread_id}/subscription", arguments.params)
     end
 
     # Create a thread subscription
@@ -160,9 +156,9 @@ def subscribed?(*args)
     #
     # @api public
     def create(*args)
-      arguments(args, required: [:id])
+      arguments(args, required: [:thread_id])
 
-      put_request("/notifications/threads/#{arguments.id}/subscription", arguments.params)
+      put_request("/notifications/threads/#{arguments.thread_id}/subscription", arguments.params)
     end
 
     # Delete a thread subscription
@@ -175,10 +171,10 @@ def create(*args)
     #
     # @api public
     def delete(*args)
-      arguments(args, required: [:id])
+      arguments(args, required: [:thread_id])
 
-      delete_request("/notifications/threads/#{arguments.id}/subscription", arguments.params)
+      delete_request("/notifications/threads/#{arguments.thread_id}/subscription", arguments.params)
     end
-    alias :remove :delete
+    alias_method :remove, :delete
   end # Client::Activity::Notifications
 end # Github
diff --git a/spec/github/client/activity/notifications/list_spec.rb b/spec/github/client/activity/notifications/list_spec.rb
@@ -23,12 +23,6 @@
 
     it { should respond_to :all }
 
-    it 'filters unknown parameters' do
-      subject.list :unknown => true
-      a_get(request_path).with(:query => {:access_token => OAUTH_TOKEN}).
-        should have_been_made
-    end
-
     it 'should get the resource' do
       subject.list
       a_get(request_path).with(:query => {:access_token => OAUTH_TOKEN}).
diff --git a/spec/github/client/activity/notifications/mark_spec.rb b/spec/github/client/activity/notifications/mark_spec.rb
@@ -26,7 +26,7 @@
     }
 
     it 'should get the resource' do
-      subject.mark inputs.merge(:unknown => true)
+      subject.mark(inputs)
       a_put(request_path).
         with(:body => inputs, :query => {:access_token => OAUTH_TOKEN}).
         should have_been_made

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`it 'should get the resource' do`
`29`		`- subject.mark inputs.merge(:unknown => true)`
	`29`	`+ subject.mark(inputs)`
`30`	`30`	`a_put(request_path).`
`31`	`31`	`with(:body => inputs, :query => {:access_token => OAUTH_TOKEN}).`
`32`	`32`	`should have_been_made`