Skip to content

Commit 3262a69

Browse files
committed
integration: simplify parallel run destination
'Namespace' parallel runs by bind-mounting a different directory in the container, instead of making the tests running inside the container aware of the namespaced location. This makes it transparent to the tests, and slightly reduces complexity. Signed-off-by: Sebastiaan van Stijn <[email protected]>
1 parent 09226c4 commit 3262a69

3 files changed

Lines changed: 2 additions & 9 deletions

File tree

Jenkinsfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -268,13 +268,13 @@ pipeline {
268268
run_tests() {
269269
[ -n "$TESTDEBUG" ] && rm= || rm=--rm;
270270
docker run $rm -t --privileged \
271-
-v "$WORKSPACE/bundles:/go/src/github.com/docker/docker/bundles" \
271+
-v "$WORKSPACE/bundles/${TEST_INTEGRATION_DEST}:/go/src/github.com/docker/docker/bundles" \
272+
-v "$WORKSPACE/bundles/dynbinary-daemon:/go/src/github.com/docker/docker/bundles/dynbinary-daemon" \
272273
-v "$WORKSPACE/.git:/go/src/github.com/docker/docker/.git" \
273274
--name "$CONTAINER_NAME" \
274275
-e KEEPBUNDLE=1 \
275276
-e TESTDEBUG \
276277
-e TESTFLAGS \
277-
-e TEST_INTEGRATION_DEST \
278278
-e TEST_SKIP_INTEGRATION \
279279
-e TEST_SKIP_INTEGRATION_CLI \
280280
-e DOCKER_GITCOMMIT=${GIT_COMMIT} \

Makefile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ DOCKER_ENVS := \
5353
-e DOCKER_TEST_HOST \
5454
-e DOCKER_USERLANDPROXY \
5555
-e DOCKERD_ARGS \
56-
-e TEST_INTEGRATION_DEST \
5756
-e TEST_INTEGRATION_DIR \
5857
-e TEST_SKIP_INTEGRATION \
5958
-e TEST_SKIP_INTEGRATION_CLI \

hack/make/test-integration

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,6 @@
11
#!/usr/bin/env bash
22
set -e -o pipefail
33

4-
if [ -n "$TEST_INTEGRATION_DEST" ]; then
5-
export DEST="$ABS_DEST/$TEST_INTEGRATION_DEST"
6-
export DOCKER_INTEGRATION_DAEMON_DEST="$DEST"
7-
mkdir -p "$DEST"
8-
fi
9-
104
source hack/make/.integration-test-helpers
115

126
if [ ! -z "${TEST_SKIP_INTEGRATION}" ] && [ ! -z "${TEST_SKIP_INTEGRATION_CLI}" ]; then

0 commit comments

Comments
 (0)