Change in JSON::Object::set(key,value) behavior in 1.6.1 pocoproject#933

aleks-f · aleks-f · commit 32956fe044da · 2015-09-12T13:17:01.000-05:00
fix according to [suggestion](pocoproject@fee347e#commitcomment-13196733)
diff --git a/JSON/src/Object.cpp b/JSON/src/Object.cpp
@@ -117,7 +117,7 @@ const std::string& Object::getKey(KeyPtrList::const_iterator& iter) const
 void Object::set(const std::string& key, const Dynamic::Var& value)
 {
 	std::pair<ValueMap::iterator, bool> ret = _values.insert(ValueMap::value_type(key, value));
-	if (!ret.second) _values[key] = value;
+	if (!ret.second) ret.first->second = value;
 	if (_preserveInsOrder)
 	{
 		KeyPtrList::iterator it = _keys.begin();

Original file line number	Diff line number	Diff line change
`@@ -117,7 +117,7 @@ const std::string& Object::getKey(KeyPtrList::const_iterator& iter) const`
`117`	`117`	`void Object::set(const std::string& key, const Dynamic::Var& value)`
`118`	`118`	`{`
`119`	`119`	`std::pair<ValueMap::iterator, bool> ret = _values.insert(ValueMap::value_type(key, value));`
`120`		`- if (!ret.second) _values[key] = value;`
	`120`	`+ if (!ret.second) ret.first->second = value;`
`121`	`121`	`if (_preserveInsOrder)`
`122`	`122`	`{`
`123`	`123`	`KeyPtrList::iterator it = _keys.begin();`