Fix warnings in headers because application/user settings control what warnings are seen when compiling against poco

Patrick White · Patrick White · commit 69f7cb984660 · 2014-01-23T16:22:38.000-05:00
diff --git a/Foundation/include/Poco/ActiveStarter.h b/Foundation/include/Poco/ActiveStarter.h
@@ -56,7 +56,7 @@ class ActiveStarter
 	/// thread pool.
 {
 public:
-	static void start(OwnerType* pOwner, ActiveRunnableBase::Ptr pRunnable)
+	static void start(OwnerType* /*pOwner*/, ActiveRunnableBase::Ptr pRunnable)
 	{
 		ThreadPool::defaultPool().start(*pRunnable);
 		pRunnable->duplicate(); // The runnable will release itself.
diff --git a/Foundation/include/Poco/BufferAllocator.h b/Foundation/include/Poco/BufferAllocator.h
@@ -61,7 +61,7 @@ class BufferAllocator
 		return new char_type[static_cast<std::size_t>(size)];
 	}
 	
-	static void deallocate(char_type* ptr, std::streamsize size)
+	static void deallocate(char_type* ptr, std::streamsize /*size*/)
 	{
 		delete [] ptr;
 	}
diff --git a/Foundation/include/Poco/BufferedBidirectionalStreamBuf.h b/Foundation/include/Poco/BufferedBidirectionalStreamBuf.h
@@ -153,12 +153,12 @@ class BasicBufferedBidirectionalStreamBuf: public std::basic_streambuf<ch, tr>
 	}
 
 private:
-	virtual int readFromDevice(char_type* buffer, std::streamsize length)
+	virtual int readFromDevice(char_type* /*buffer*/, std::streamsize /*length*/)
 	{
 		return 0;
 	}
 
-	virtual int writeToDevice(const char_type* buffer, std::streamsize length)
+	virtual int writeToDevice(const char_type* /*buffer*/, std::streamsize /*length*/)
 	{
 		return 0;
 	}
diff --git a/Foundation/include/Poco/BufferedStreamBuf.h b/Foundation/include/Poco/BufferedStreamBuf.h
@@ -146,12 +146,12 @@ class BasicBufferedStreamBuf: public std::basic_streambuf<ch, tr>
 	}
 
 private:
-	virtual int readFromDevice(char_type* buffer, std::streamsize length)
+	virtual int readFromDevice(char_type* /*buffer*/, std::streamsize /*length*/)
 	{
 		return 0;
 	}
 
-	virtual int writeToDevice(const char_type* buffer, std::streamsize length)
+	virtual int writeToDevice(const char_type* /*buffer*/, std::streamsize /*length*/)
 	{
 		return 0;
 	}
diff --git a/Foundation/include/Poco/FunctionDelegate.h b/Foundation/include/Poco/FunctionDelegate.h
@@ -217,7 +217,7 @@ class FunctionDelegate<TArgs, false, senderIsConst>: public AbstractDelegate<TAr
 		return *this;
 	}
 
-	bool notify(const void* sender, TArgs& arguments)
+	bool notify(const void* /*sender*/, TArgs& arguments)
 	{
 		Mutex::ScopedLock lock(_mutex);
 		if (_receiverMethod)
@@ -427,7 +427,7 @@ class FunctionDelegate<void, false, senderIsConst>: public AbstractDelegate<void
 		return *this;
 	}
 
-	bool notify(const void* sender)
+	bool notify(const void* /*sender*/)
 	{
 		Mutex::ScopedLock lock(_mutex);
 		if (_receiverMethod)
diff --git a/Foundation/include/Poco/MemoryStream.h b/Foundation/include/Poco/MemoryStream.h
@@ -84,7 +84,7 @@ class BasicMemoryStreamBuf: public std::basic_streambuf<ch, tr>
 	{
 	}
 
-	virtual int_type overflow(int_type c)
+	virtual int_type overflow(int_type /*c*/)
 	{
 		return char_traits::eof();
 	}
diff --git a/Foundation/include/Poco/MetaObject.h b/Foundation/include/Poco/MetaObject.h
@@ -207,7 +207,7 @@ class MetaSingleton: public AbstractMetaObject<B>
 		return *_object.get();
 	}
 
-	bool isAutoDelete(B* pObject) const
+	bool isAutoDelete(B* /*pObject*/) const
 	{
 		return true;
 	}
diff --git a/Foundation/include/Poco/RotateStrategy.h b/Foundation/include/Poco/RotateStrategy.h
@@ -114,7 +114,7 @@ class RotateAtTimeStrategy: public RotateStrategy
 	{
 	}
 	
-	bool mustRotate(LogFile* pFile)
+	bool mustRotate(LogFile* /*pFile*/)
 	{
 		if (DT() >= _threshold)
 		{
diff --git a/Foundation/include/Poco/Void.h b/Foundation/include/Poco/Void.h
@@ -77,13 +77,13 @@ class Foundation_API Void
 };
 
 
-inline bool Void::operator ==(const Void& v) const
+inline bool Void::operator ==(const Void& /*v*/) const
 {
 	return true;
 }
 
 
-inline bool Void::operator !=(const Void& v) const
+inline bool Void::operator !=(const Void& /*v*/) const
 {
 	return false;
 }
diff --git a/JSON/include/Poco/JSON/Object.h b/JSON/include/Poco/JSON/Object.h
@@ -229,7 +229,7 @@ class JSON_API Object
 
 private:
 	template <typename C>
-	void doStringify(const C& container, std::ostream& out, unsigned int indent, int step) const
+	void doStringify(const C& container, std::ostream& out, unsigned int indent, unsigned int step) const
 	{
 		out << '{';
 
@@ -239,7 +239,7 @@ class JSON_API Object
 		typename C::const_iterator end = container.end();
 		for (; it != end;)
 		{
-			for(int i = 0; i < indent; i++) out << ' ';
+			for(unsigned int i = 0; i < indent; i++) out << ' ';
 
 			out << '"' << getKey(it) << '"';
 			out << ((indent > 0) ? " : " : ":");
@@ -248,12 +248,12 @@ class JSON_API Object
 
 			if ( ++it != container.end() ) out << ',';
 
-			if (step > 0) out << '\n';
+			if (step > 0) out << std::endl;
 		}
 
 		if (indent >= step) indent -= step;
 
-		for (int i = 0; i < indent; i++)
+		for (unsigned int i = 0; i < indent; i++)
 			out << ' ';
 
 		out << '}';
diff --git a/JSON/src/Object.cpp b/JSON/src/Object.cpp
@@ -112,7 +112,7 @@ void Object::getNames(std::vector<std::string>& names) const
 
 void Object::stringify(std::ostream& out, unsigned int indent, int step) const
 {
-	if (step == -1) step = indent;
+	if (step < 0) step = indent;
 
 	if(!_preserveInsOrder)
 		doStringify(_values, out, indent, step);

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ class ActiveStarter`
`56`	`56`	`/// thread pool.`
`57`	`57`	`{`
`58`	`58`	`public:`
`59`		`- static void start(OwnerType* pOwner, ActiveRunnableBase::Ptr pRunnable)`
	`59`	`+ static void start(OwnerType* /pOwner/, ActiveRunnableBase::Ptr pRunnable)`
`60`	`60`	`{`
`61`	`61`	`ThreadPool::defaultPool().start(*pRunnable);`
`62`	`62`	`pRunnable->duplicate(); // The runnable will release itself.`
Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ class BufferAllocator`
`61`	`61`	`return new char_type[static_cast<std::size_t>(size)];`
`62`	`62`	`}`
`63`	`63`
`64`		`- static void deallocate(char_type* ptr, std::streamsize size)`
	`64`	`+ static void deallocate(char_type* ptr, std::streamsize /size/)`
`65`	`65`	`{`
`66`	`66`	`delete [] ptr;`
`67`	`67`	`}`
Original file line number	Diff line number	Diff line change
`@@ -153,12 +153,12 @@ class BasicBufferedBidirectionalStreamBuf: public std::basic_streambuf<ch, tr>`
`153`	`153`	`}`
`154`	`154`
`155`	`155`	`private:`
`156`		`- virtual int readFromDevice(char_type* buffer, std::streamsize length)`
	`156`	`+ virtual int readFromDevice(char_type* /buffer/, std::streamsize /length/)`
`157`	`157`	`{`
`158`	`158`	`return 0;`
`159`	`159`	`}`
`160`	`160`
`161`		`- virtual int writeToDevice(const char_type* buffer, std::streamsize length)`
	`161`	`+ virtual int writeToDevice(const char_type* /buffer/, std::streamsize /length/)`
`162`	`162`	`{`
`163`	`163`	`return 0;`
`164`	`164`	`}`
Original file line number	Diff line number	Diff line change
`@@ -146,12 +146,12 @@ class BasicBufferedStreamBuf: public std::basic_streambuf<ch, tr>`
`146`	`146`	`}`
`147`	`147`
`148`	`148`	`private:`
`149`		`- virtual int readFromDevice(char_type* buffer, std::streamsize length)`
	`149`	`+ virtual int readFromDevice(char_type* /buffer/, std::streamsize /length/)`
`150`	`150`	`{`
`151`	`151`	`return 0;`
`152`	`152`	`}`
`153`	`153`
`154`		`- virtual int writeToDevice(const char_type* buffer, std::streamsize length)`
	`154`	`+ virtual int writeToDevice(const char_type* /buffer/, std::streamsize /length/)`
`155`	`155`	`{`
`156`	`156`	`return 0;`
`157`	`157`	`}`
Original file line number	Diff line number	Diff line change
`@@ -217,7 +217,7 @@ class FunctionDelegate<TArgs, false, senderIsConst>: public AbstractDelegate<TAr`
`217`	`217`	`return *this;`
`218`	`218`	`}`
`219`	`219`
`220`		`- bool notify(const void* sender, TArgs& arguments)`
	`220`	`+ bool notify(const void* /sender/, TArgs& arguments)`
`221`	`221`	`{`
`222`	`222`	`Mutex::ScopedLock lock(_mutex);`
`223`	`223`	`if (_receiverMethod)`
`@@ -427,7 +427,7 @@ class FunctionDelegate<void, false, senderIsConst>: public AbstractDelegate<void`
`427`	`427`	`return *this;`
`428`	`428`	`}`
`429`	`429`
`430`		`- bool notify(const void* sender)`
	`430`	`+ bool notify(const void* /sender/)`
`431`	`431`	`{`
`432`	`432`	`Mutex::ScopedLock lock(_mutex);`
`433`	`433`	`if (_receiverMethod)`
Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ class BasicMemoryStreamBuf: public std::basic_streambuf<ch, tr>`
`84`	`84`	`{`
`85`	`85`	`}`
`86`	`86`
`87`		`- virtual int_type overflow(int_type c)`
	`87`	`+ virtual int_type overflow(int_type /c/)`
`88`	`88`	`{`
`89`	`89`	`return char_traits::eof();`
`90`	`90`	`}`
Original file line number	Diff line number	Diff line change
`@@ -207,7 +207,7 @@ class MetaSingleton: public AbstractMetaObject<B>`
`207`	`207`	`return *_object.get();`
`208`	`208`	`}`
`209`	`209`
`210`		`- bool isAutoDelete(B* pObject) const`
	`210`	`+ bool isAutoDelete(B* /pObject/) const`
`211`	`211`	`{`
`212`	`212`	`return true;`
`213`	`213`	`}`
Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,7 @@ class RotateAtTimeStrategy: public RotateStrategy`
`114`	`114`	`{`
`115`	`115`	`}`
`116`	`116`
`117`		`- bool mustRotate(LogFile* pFile)`
	`117`	`+ bool mustRotate(LogFile* /pFile/)`
`118`	`118`	`{`
`119`	`119`	`if (DT() >= _threshold)`
`120`	`120`	`{`
Original file line number	Diff line number	Diff line change
`@@ -77,13 +77,13 @@ class Foundation_API Void`
`77`	`77`	`};`
`78`	`78`
`79`	`79`
`80`		`-inline bool Void::operator ==(const Void& v) const`
	`80`	`+inline bool Void::operator ==(const Void& /v/) const`
`81`	`81`	`{`
`82`	`82`	`return true;`
`83`	`83`	`}`
`84`	`84`
`85`	`85`
`86`		`-inline bool Void::operator !=(const Void& v) const`
	`86`	`+inline bool Void::operator !=(const Void& /v/) const`
`87`	`87`	`{`
`88`	`88`	`return false;`
`89`	`89`	`}`