add parameter to disable changing of owner and group of requirements file

saz · saz · commit bd1e2cf70558 · 2014-09-03T15:54:05.000+02:00
diff --git a/manifests/requirements.pp b/manifests/requirements.pp
@@ -38,6 +38,9 @@
 # [*extra_pip_args*]
 # Extra arguments to pass to pip after the requirements file
 #
+# [*fix_requirements_owner*]
+# Change owner and group of requirements file. Default: true
+#
 # === Examples
 #
 # python::requirements { '/var/www/project1/requirements.txt':
@@ -52,22 +55,31 @@
 # Fotis Gimian
 #
 define python::requirements (
-  $requirements = $name,
-  $virtualenv   = 'system',
-  $owner        = 'root',
-  $group        = 'root',
-  $proxy        = false,
-  $src          = false,
-  $environment  = [],
-  $forceupdate  = false,
-  $cwd          = undef,
-  $extra_pip_args = '',
+  $requirements           = $name,
+  $virtualenv             = 'system',
+  $owner                  = 'root',
+  $group                  = 'root',
+  $proxy                  = false,
+  $src                    = false,
+  $environment            = [],
+  $forceupdate            = false,
+  $cwd                    = undef,
+  $extra_pip_args         = '',
+  $fix_requirements_owner = true
 ) {
 
   if $virtualenv == 'system' and ($owner != 'root' or $group != 'root') {
     fail('python::pip: root user must be used when virtualenv is system')
   }
 
+  if $fix_requirements_owner {
+    $owner_real = $owner
+    $group_real = $group
+  } else {
+    $owner_real = undef
+    $group_real = undef
+  }
+
   $rootdir = $virtualenv ? {
     'system' => '/',
     default  => $virtualenv,
@@ -94,8 +106,8 @@
     file { $requirements:
       ensure  => present,
       mode    => '0644',
-      owner   => $owner,
-      group   => $group,
+      owner   => $owner_real,
+      group   => $group_real,
       audit   => content,
       replace => false,
       content => '# Puppet will install and/or update pip packages listed here',
