Skip to content

Commit 57cdfa9

Browse files
author
Shiva Poudel
committed
Semantic code performed
1 parent f04e2db commit 57cdfa9

1 file changed

Lines changed: 23 additions & 44 deletions

File tree

spec/classes/python_spec.rb

Lines changed: 23 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -50,13 +50,13 @@
5050

5151
describe "with python::provider" do
5252
context "pip" do
53-
let (:params) {{ :provider => 'pip' }}
53+
let (:params) {{ :provider => 'pip' }}
5454
it { is_expected.to contain_package("virtualenv").with(
55-
"provider" => "pip"
56-
)}
55+
'provider' => 'pip'
56+
)}
5757
it { is_expected.to contain_package("pip").with(
58-
"provider" => "pip"
59-
)}
58+
'provider' => 'pip'
59+
)}
6060
end
6161

6262
# python::provider
@@ -90,7 +90,7 @@
9090
let (:params) {{ :dev => '' }}
9191
it { is_expected.to contain_package("python-dev").with_ensure('absent') }
9292
end
93-
93+
end
9494
end
9595

9696
context "on a Redhat 5 OS" do
@@ -115,18 +115,13 @@
115115

116116
describe "with python::dev" do
117117
context "true" do
118-
let (:params) {{ :dev => true }}
119-
it { is_expected.to contain_package("python-devel").with(
120-
"ensure" => "present")
121-
}
118+
let (:params) {{ :dev => true }}
119+
it { is_expected.to contain_package("python-devel").with_ensure('present') }
122120
end
123121
context "empty/default" do
124-
it { is_expected.to contain_package("python-devel").with(
125-
"ensure" => "absent")
126-
}
122+
it { is_expected.to contain_package("python-devel").with_ensure('absent') }
127123
end
128124
end
129-
130125

131126
describe "with manage_gunicorn" do
132127
context "true" do
@@ -145,13 +140,14 @@
145140

146141
describe "with python::provider" do
147142
context "pip" do
148-
let (:params) {{ :provider => 'pip' }}
143+
let (:params) {{ :provider => 'pip' }}
144+
149145
it { is_expected.to contain_package("virtualenv").with(
150-
"provider" => "pip"
151-
)}
146+
'provider' => 'pip'
147+
)}
152148
it { is_expected.to contain_package("pip").with(
153-
"provider" => "pip"
154-
)}
149+
'provider' => 'pip'
150+
)}
155151
end
156152

157153
# python::provider
@@ -162,46 +158,29 @@
162158

163159
describe "with python::virtualenv" do
164160
context "true" do
165-
let (:params) {{
166-
:provider => '',
167-
:virtualenv => true
168-
}}
169-
it { is_expected.to contain_package("python-virtualenv").with(
170-
"ensure" => "present"
171-
)}
161+
let (:params) {{ :provider => '', :virtualenv => true }}
162+
it { is_expected.to contain_package("python-virtualenv").with_ensure('present') }
172163
end
173164
end
174165

175166
describe "with python::virtualenv" do
176167
context "default/empty" do
177-
let (:params) {{
178-
:provider => '',
179-
:virtualenv => ''
180-
}}
181-
it { is_expected.to contain_package("python-virtualenv").with(
182-
"ensure" => "absent"
183-
)}
168+
let (:params) {{ :provider => '', :virtualenv => '' }}
169+
it { is_expected.to contain_package("python-virtualenv").with_ensure('present') }
184170
end
185171
end
186-
187-
188172
end
189173
end
190174

191175
describe "with python::dev" do
192176
context "true" do
193177
let (:params) {{ :dev => true }}
194-
it { is_expected.to contain_package("python-devel").with(
195-
"ensure" => "present")
196-
}
178+
it { is_expected.to contain_package("python-devel").with_ensure('present') }
197179
end
198180
context "default/empty" do
199181
let (:params) {{ :dev => '' }}
200-
it { is_expected.to contain_package("python-devel").with(
201-
"ensure" => "absent")
202-
}
203-
end
182+
it { is_expected.to contain_package("python-devel").with_ensure('absent') }
204183
end
205184
end
206-
end
207-
end
185+
end
186+
end

0 commit comments

Comments
 (0)