Fix tests

vtm9 · vtm9 · commit 70c578c11f90 · 2021-10-01T14:22:35.000+03:00
diff --git a/services/app/test/codebattle_web/controllers/task_controller_test.exs b/services/app/test/codebattle_web/controllers/task_controller_test.exs
@@ -69,7 +69,7 @@ defmodule CodebattleWeb.TaskControllerTest do
       "input_signature" =>
         "[{\"argument-name\":\"a\",\"type\":{\"name\":\"integer\"}},{\"argument-name\":\"b\",\"type\":{\"name\":\"integer\"}}]",
       "level" => "easy",
-      "name" => "task_easy_1",
+      "name" => "asdfasdf",
       "output_signature" => "{\"type\":{\"name\":\"integer\"}}",
       "tags" => " kek,lol, asdf    "
     }
@@ -85,7 +85,7 @@ defmodule CodebattleWeb.TaskControllerTest do
     conn = get(conn, Routes.task_path(conn, :show, id))
     assert html_response(conn, 200)
 
-    task = Codebattle.Repo.get(Codebattle.Task, id)
+    task = Codebattle.Task.get!(id)
     user_id = user.id
 
     assert %{
@@ -100,7 +100,7 @@ defmodule CodebattleWeb.TaskControllerTest do
                %{"argument-name" => "b", "type" => %{"name" => "integer"}}
              ],
              level: "easy",
-             name: "task_easy_1",
+             name: "asdfasdf",
              origin: "user",
              output_signature: %{"type" => %{"name" => "integer"}},
              state: "draft",
@@ -134,7 +134,7 @@ defmodule CodebattleWeb.TaskControllerTest do
     assert %{id: id} = redirected_params(conn)
     assert redirected_to(conn) == Routes.task_path(conn, :edit, id)
 
-    task = Codebattle.Repo.get(Codebattle.Task, id)
+    task = Codebattle.Task.get!(id)
 
     assert %{
              asserts:
@@ -173,7 +173,7 @@ defmodule CodebattleWeb.TaskControllerTest do
 
     assert redirected_to(new_conn) == Routes.task_path(conn, :index)
 
-    task = Codebattle.Repo.get(Codebattle.Task, task.id)
+    task = Codebattle.Task.get!(task.id)
 
     assert task.state == "active"
   end
@@ -197,7 +197,7 @@ defmodule CodebattleWeb.TaskControllerTest do
 
     assert redirected_to(new_conn) == Routes.task_path(conn, :index)
 
-    task = Codebattle.Repo.get(Codebattle.Task, task.id)
+    task = Codebattle.Task.get!(task.id)
 
     assert task.state == "disabled"
   end
diff --git a/services/app/test/codebattle_web/plugs/assign_current_user_test.exs b/services/app/test/codebattle_web/plugs/assign_current_user_test.exs
@@ -4,7 +4,7 @@ defmodule CodebattleWeb.Plugs.AssignCurrentUserTest do
   test "clear session if user have id in session, but doesn't have db record", %{conn: conn} do
     conn =
       conn
-      |> put_session(:user_id, 1)
+      |> put_session(:user_id, 1_000_000)
       |> get(Routes.page_path(conn, :index))
 
     assert conn.status == 200
diff --git a/services/app/test/support/factory.ex b/services/app/test/support/factory.ex
@@ -140,7 +140,11 @@ defmodule CodebattleWeb.Factory do
   end
 
   def task_pack_factory do
-    %TaskPack{name: "asdf", visibility: "public", state: "active"}
+    %TaskPack{
+      name: sequence(:taskpack, &"Pack #{&1}"),
+      visibility: "public",
+      state: "active"
+    }
   end
 
   def playbook_factory do
