Updating tests

cnu1439 · cnu1439 · commit 105f2609cb9f · 2025-12-13T19:48:13.000+05:30
diff --git a/tests/test_client.py b/tests/test_client.py
@@ -1,6 +1,6 @@
 """Tests for the SDK client."""
 
-from unittest.mock import AsyncMock, MagicMock, patch
+from unittest.mock import AsyncMock, MagicMock
 
 import pytest
 
@@ -49,10 +49,10 @@ def test_sync_sdk_initialization() -> None:
 
 
 def test_sdk_requires_secret() -> None:
-    """Test that SDK requires a secret."""
-    with patch.dict("os.environ", {}, clear=True):
-        with pytest.raises(ValueError, match="Agent secret must be provided"):
-            AsyncValueClient(secret="")
+    """Test that SDK requires a secret (positional argument)."""
+    # secret is now a required positional argument, so calling without it raises TypeError
+    with pytest.raises(TypeError):
+        AsyncValueClient()  # type: ignore
 
 
 def test_custom_endpoints() -> None:
diff --git a/tests/test_config.py b/tests/test_config.py
@@ -5,14 +5,21 @@
 
 def test_config_with_defaults() -> None:
     """Test config with default values."""
-    config = SDKConfig(secret="test-secret")
-    assert config.secret == "test-secret"
+    config = SDKConfig()
     assert config.otel_endpoint == "http://localhost:4317"
     assert config.service_name == "value-control-agent"
     assert config.enable_console_export is False
 
 
-def test_config_allows_empty_secret() -> None:
-    """Test that config allows empty secret (validation is done in client)."""
-    config = SDKConfig(secret="")
-    assert config.secret == ""
+def test_config_custom_values() -> None:
+    """Test config with custom values."""
+    config = SDKConfig(
+        otel_endpoint="http://custom:4317",
+        backend_url="https://custom.api",
+        service_name="my-service",
+        enable_console_export=True,
+    )
+    assert config.otel_endpoint == "http://custom:4317"
+    assert config.backend_url == "https://custom.api"
+    assert config.service_name == "my-service"
+    assert config.enable_console_export is True
