refactor(index-context): consolidate directory indexing methods into single function

zTgx · zTgx · commit 32d81bbc8b3a · 2026-04-15T13:31:28.000+08:00
BREAKING CHANGE: The IndexContext::from_dir_recursive method has been removed
and replaced with a boolean parameter in the from_dir method.

- Replace separate from_dir and from_dir_recursive methods with unified
  from_dir(path, recursive) method
- Update Python binding to use the new unified method signature
- Update documentation examples to reflect the new API
- Rename test function to match new naming convention
diff --git a/python/src/lib.rs b/python/src/lib.rs
@@ -226,11 +226,7 @@ impl PyIndexContext {
     #[staticmethod]
     #[pyo3(signature = (path, recursive=false))]
     fn from_dir(path: String, recursive: bool) -> Self {
-        let inner = if recursive {
-            IndexContext::from_dir_recursive(&path)
-        } else {
-            IndexContext::from_dir(&path)
-        };
+        let inner = IndexContext::from_dir(&path, recursive);
         Self { inner }
     }
 
diff --git a/rust/examples/index_directory.rs b/rust/examples/index_directory.rs
@@ -46,13 +46,8 @@ async fn main() -> vectorless::Result<()> {
         .map_err(|e| vectorless::Error::Config(e.to_string()))?;
 
     // Index directory
-    let ctx = if recursive {
-        println!("Recursively indexing: {}", dir);
-        IndexContext::from_dir_recursive(dir)
-    } else {
-        println!("Indexing top-level files in: {}", dir);
-        IndexContext::from_dir(dir)
-    };
+    println!("{}indexing: {}", if recursive { "Recursively " } else { "" }, dir);
+    let ctx = IndexContext::from_dir(dir, recursive);
 
     if ctx.is_empty() {
         println!("No supported files found in: {}", dir);
diff --git a/rust/src/client/index_context.rs b/rust/src/client/index_context.rs
@@ -30,10 +30,10 @@
 //! use vectorless::client::IndexContext;
 //!
 //! // Non-recursive (top-level only)
-//! let ctx = IndexContext::from_dir("./documents");
+//! let ctx = IndexContext::from_dir("./documents", false);
 //!
 //! // Recursive (includes subdirectories)
-//! let ctx = IndexContext::from_dir_recursive("./documents");
+//! let ctx = IndexContext::from_dir("./documents", true);
 //! ```
 
 use std::path::PathBuf;
@@ -93,7 +93,7 @@ pub(crate) enum IndexSource {
 /// ).await?;
 ///
 /// // Entire directory
-/// let result = engine.index(IndexContext::from_dir("./docs")).await?;
+/// let result = engine.index(IndexContext::from_dir("./docs", false)).await?;
 /// # Ok(())
 /// # }
 /// ```
@@ -135,18 +135,12 @@ impl IndexContext {
 
     /// Create from a directory path.
     ///
-    /// Indexes all supported files in the directory (non-recursive).
+    /// Indexes all supported files in the directory.
     /// Supported extensions: `.md`, `.pdf`.
-    pub fn from_dir(dir: impl Into<PathBuf>) -> Self {
-        Self::scan_dir(dir, false)
-    }
-
-    /// Create from a directory path with recursive scanning.
     ///
-    /// Recursively indexes all supported files in the directory and its
-    /// subdirectories. Supported extensions: `.md`, `.pdf`.
-    pub fn from_dir_recursive(dir: impl Into<PathBuf>) -> Self {
-        Self::scan_dir(dir, true)
+    /// Set `recursive` to `true` to include subdirectories.
+    pub fn from_dir(dir: impl Into<PathBuf>, recursive: bool) -> Self {
+        Self::scan_dir(dir, recursive)
     }
 
     /// Internal: scan a directory for supported document files.
@@ -340,7 +334,7 @@ mod tests {
     }
 
     #[test]
-    fn test_from_dir_recursive() {
+    fn test_from_dir_with_recursive() {
         // Create a temp directory structure:
         //   tmp/
         //     a.md
@@ -357,11 +351,11 @@ mod tests {
         std::fs::write(tmp.join("sub/deep/ignore.dat"), b"xxx").unwrap();
 
         // Non-recursive: only top-level
-        let ctx = IndexContext::from_dir(&tmp);
+        let ctx = IndexContext::from_dir(&tmp, false);
         assert_eq!(ctx.len(), 1); // only a.md
 
         // Recursive: all levels
-        let ctx = IndexContext::from_dir_recursive(&tmp);
+        let ctx = IndexContext::from_dir(&tmp, true);
         assert_eq!(ctx.len(), 3); // a.md, b.md, c.pdf
 
         let _ = std::fs::remove_dir_all(&tmp);
diff --git a/rust/src/lib.rs b/rust/src/lib.rs
@@ -77,8 +77,5 @@ pub use graph::DocumentGraph;
 // Event types
 pub use events::{EventEmitter, IndexEvent, QueryEvent, WorkspaceEvent};
 
-// Index metrics
-pub use metrics::IndexMetrics;
-
 // Runtime metrics reports
-pub use metrics::{LlmMetricsReport, MetricsReport, PilotMetricsReport, RetrievalMetricsReport};
+pub use metrics::{IndexMetrics, LlmMetricsReport, MetricsReport, PilotMetricsReport, RetrievalMetricsReport};
