Fix issue with creatures when quick-switching casts in OTs (jo3bingham#37)

jo3bingham · web-flow · commit f34e4b1741a2 · 2020-08-13T10:36:56.000-04:00
diff --git a/TibiaAPI/Network/NetworkMessage.cs b/TibiaAPI/Network/NetworkMessage.cs
@@ -453,7 +453,12 @@ public Creature ReadCreatureInstance(int id = -1, Position position = null)
                         creature = _client.CreatureStorage.GetCreature(creatureId);
                         if (creature == null)
                         {
-                            throw new Exception("[NetworkMessage.ReadCreatureInstance] Outdated creature not found.");
+                            // This should never occur on official servers, but has been observed
+                            // on Open-Tibia servers via cast system. Log the error and create
+                            // a new Creature so that the parser can continue gracefully.
+                            _client.Logger.Error("[NetworkMessage.ReadCreatureInstance] Outdated creature not found.");
+                            creature = new Creature(creatureId);
+                            creature = _client.CreatureStorage.ReplaceCreature(creature);
                         }
 
                         creature.InstanceType = (CreatureInstanceType)id;
@@ -501,7 +506,12 @@ public Creature ReadCreatureInstance(int id = -1, Position position = null)
                         creature = _client.CreatureStorage.GetCreature(creatureId);
                         if (creature == null)
                         {
-                            throw new Exception("[NetworkMessage.ReadCreatureInstance] Known creature not found.");
+                            // This should never occur on official servers, but has been observed
+                            // on Open-Tibia servers via cast system. Log the error and create
+                            // a new Creature so that the parser can continue gracefully.
+                            _client.Logger.Error("[NetworkMessage.ReadCreatureInstance] Known creature not found.");
+                            creature = new Creature(creatureId);
+                            creature = _client.CreatureStorage.ReplaceCreature(creature);
                         }
 
                         creature.InstanceType = (CreatureInstanceType)id;
