fix:leaky st

InferROI2023 · InferROI2023 · commit e86f052d9ce6 · 2023-07-30T06:47:23.000Z
diff --git a/JavaSecurity/CodeReview/JavaSec-Code/MybatiSqli/src/main/java/com/drunkbaby/controller/SQLI.java b/JavaSecurity/CodeReview/JavaSec-Code/MybatiSqli/src/main/java/com/drunkbaby/controller/SQLI.java
@@ -120,14 +120,17 @@ public String jdbc_sqli_sec(@RequestParam("username") String username) {
                 logger.info(info);
             }
 
-            rs.close();
-            con.close();
+           
 
         } catch (ClassNotFoundException e) {
             logger.error("Sorry, can`t find the Driver!");
             e.printStackTrace();
         } catch (SQLException e) {
             logger.error(e.toString());
+        } finally {
+            st.close();
+            rs.close();
+            con.close();
         }
         return result.toString();
     }

Original file line number	Diff line number	Diff line change
`@@ -120,14 +120,17 @@ public String jdbc_sqli_sec(@RequestParam("username") String username) {`
`120`	`120`	`logger.info(info);`
`121`	`121`	`}`
`122`	`122`
`123`		`- rs.close();`
`124`		`- con.close();`
	`123`	`+`
`125`	`124`
`126`	`125`	`} catch (ClassNotFoundException e) {`
`127`	`126`	logger.error("Sorry, can`t find the Driver!");
`128`	`127`	`e.printStackTrace();`
`129`	`128`	`} catch (SQLException e) {`
`130`	`129`	`logger.error(e.toString());`
	`130`	`+ } finally {`
	`131`	`+ st.close();`
	`132`	`+ rs.close();`
	`133`	`+ con.close();`
`131`	`134`	`}`
`132`	`135`	`return result.toString();`
`133`	`136`	`}`