Now that all exec statements run under a particular owner, there is no need for the CPU intensive recursive virtualenv permission check

fgimian · fgimian · commit f6fd9f46fe9c · 2013-06-03T20:48:10.000+10:00
diff --git a/manifests/virtualenv.pp b/manifests/virtualenv.pp
@@ -84,22 +84,13 @@
         default => "-i ${index}",
     }
 
-
     exec { "python_virtualenv_${venv_dir}":
       command => "mkdir -p ${venv_dir} ${proxy_command} && virtualenv -p `which ${python}` ${system_pkgs_flag} ${venv_dir} && ${venv_dir}/bin/pip install ${pypi_index} ${proxy_flag} --upgrade ${distribute_pkg} pip",
       user    => $owner,
       creates => "${venv_dir}/bin/activate",
       path    => [ '/bin', '/usr/bin', '/usr/sbin' ],
     }
 
-    file{$venv_dir:
-      ensure  => directory,
-      owner   => $owner,
-      group   => $group,
-      recurse => true,
-      require => Exec["python_virtualenv_${venv_dir}"],
-    }
-
     if $requirements {
       exec { "python_requirements_initial_install_${requirements}_${venv_dir}":
         command     => "${venv_dir}/bin/pip install ${pypi_index} ${proxy_flag} --requirement ${requirements}",
