Fix "twitchy fingers" bug in CameraView

mcginty · moxie0 · commit 5fd5b1e1edcb · 2015-11-06T15:00:29.000-08:00
better diagnostic information, too. Fixes signalapp#4422 Closes signalapp#4427 // FREEBIE
diff --git a/src/org/thoughtcrime/securesms/components/camera/CameraUtils.java b/src/org/thoughtcrime/securesms/components/camera/CameraUtils.java
@@ -1,10 +1,7 @@
 package org.thoughtcrime.securesms.components.camera;
 
-import android.annotation.TargetApi;
 import android.hardware.Camera;
-import android.hardware.Camera.Parameters;
 import android.hardware.Camera.Size;
-import android.os.Build.VERSION;
 import android.support.annotation.NonNull;
 import android.support.annotation.Nullable;
 
@@ -14,24 +11,13 @@
 
 @SuppressWarnings("deprecation")
 public class CameraUtils {
-  @TargetApi(11)
-  public static @Nullable Size getPreferredPreviewSize(int orientation, int width, int height, @NonNull Camera camera) {
-    final Parameters parameters    = camera.getParameters();
-    final Size       preferredSize = VERSION.SDK_INT > 11
-                                   ? parameters.getPreferredPreviewSizeForVideo()
-                                   : null;
-
-    return preferredSize == null ? getBestAspectPreviewSize(orientation, width, height, parameters)
-                                 : preferredSize;
-  }
-
   /*
    * modified from: https://github.com/commonsguy/cwac-camera/blob/master/camera/src/com/commonsware/cwac/camera/CameraUtils.java
    */
-  public static @Nullable Size getBestAspectPreviewSize(int displayOrientation,
-                                                        int width,
-                                                        int height,
-                                                        Parameters parameters) {
+  public static @Nullable Size getPreferredPreviewSize(int displayOrientation,
+                                                       int width,
+                                                       int height,
+                                                       @NonNull Camera camera) {
     double targetRatio = (double)width / height;
     Size   optimalSize = null;
     double minDiff     = Double.MAX_VALUE;
@@ -40,7 +26,7 @@ public class CameraUtils {
       targetRatio = (double)height / width;
     }
 
-    List<Size> sizes = parameters.getSupportedPreviewSizes();
+    List<Size> sizes = camera.getParameters().getSupportedPreviewSizes();
 
     Collections.sort(sizes, Collections.reverseOrder(new SizeComparator()));
 
diff --git a/src/org/thoughtcrime/securesms/components/camera/CameraView.java b/src/org/thoughtcrime/securesms/components/camera/CameraView.java
@@ -90,19 +90,17 @@ public void onResume() {
       @Override
       protected @Nullable Camera onRunBackground() {
         try {
-          if (cameraId >= 0) {
-            return Camera.open(cameraId);
-          } else {
-            return null;
-          }
+          return Camera.open(cameraId);
         } catch (Exception e) {
+          Log.w(TAG, e);
           return null;
         }
       }
 
       @Override
       protected void onPostMain(@Nullable Camera camera) {
         if (camera == null) {
+          Log.w(TAG, "tried to open camera but got null");
           if (listener != null) listener.onCameraFail();
           return;
         }
@@ -132,17 +130,23 @@ public void onPause() {
     if (!started) return;
     started = false;
     Log.w(TAG, "onPause() queued");
-    final Optional<Camera> cameraToDestroy = camera;
 
     enqueueTask(new SerialAsyncTask<Void>() {
+      private Optional<Camera> cameraToDestroy;
       @Override protected void onPreMain() {
+        cameraToDestroy = camera;
         camera = Optional.absent();
       }
 
       @Override protected Void onRunBackground() {
         if (cameraToDestroy.isPresent()) {
-          stopPreview();
-          cameraToDestroy.get().release();
+          try {
+            stopPreview();
+            cameraToDestroy.get().release();
+            Log.w(TAG, "released old camera instance");
+          } catch (Exception e) {
+            Log.w(TAG, e);
+          }
         }
         return null;
       }
@@ -171,6 +175,7 @@ protected void onMeasure(int widthMeasureSpec, int heightMeasureSpec) {
                                                                             camera.get());
       final Parameters parameters = camera.get().getParameters();
       if (preferredPreviewSize != null && !parameters.getPreviewSize().equals(preferredPreviewSize)) {
+        Log.w(TAG, "setting preview size to " + preferredPreviewSize.width + "x" + preferredPreviewSize.height);
         stopPreview();
         parameters.setPreviewSize(preferredPreviewSize.width, preferredPreviewSize.height);
         camera.get().setParameters(parameters);
@@ -239,7 +244,6 @@ public void flipCamera() {
     }
   }
 
-
   @TargetApi(14)
   private void onCameraReady() {
     if (!camera.isPresent()) return;
@@ -262,8 +266,8 @@ private void onCameraReady() {
         if (camera.isPresent()) {
           try {
             camera.get().setPreviewDisplay(surface.getHolder());
-            startPreview();
-          } catch (IOException e) {
+            requestLayout();
+          } catch (Exception e) {
             Log.w(TAG, e);
           }
         }
@@ -273,13 +277,21 @@ private void onCameraReady() {
 
   private void startPreview() {
     if (camera.isPresent()) {
-      camera.get().startPreview();
+      try {
+        camera.get().startPreview();
+      } catch (Exception e) {
+        Log.w(TAG, e);
+      }
     }
   }
 
   private void stopPreview() {
     if (camera.isPresent()) {
-      camera.get().stopPreview();
+      try {
+        camera.get().stopPreview();
+      } catch (Exception e) {
+        Log.w(TAG, e);
+      }
     }
   }
 
@@ -304,8 +316,7 @@ private void setCameraDisplayOrientation() {
     if (info.facing == Camera.CameraInfo.CAMERA_FACING_FRONT) {
       displayOrientation = (info.orientation + degrees           ) % 360;
       displayOrientation = (360              - displayOrientation) % 360;
-    }
-    else {
+    } else {
       displayOrientation = (info.orientation - degrees + 360) % 360;
     }
 
@@ -401,7 +412,7 @@ public void onPreviewFrame(byte[] data, final Camera camera) {
         Log.w(TAG, "previewFormat: " + camera.getParameters().getPreviewFormat());
         Log.w(TAG, "croppingRect: " + croppingRect.toString());
         Log.w(TAG, "rotation: " + rotation);
-        new RotatePreviewAsyncTask(previewSize, rotation, croppingRect).execute(data);
+        new CaptureTask(previewSize, rotation, croppingRect).execute(data);
       }
     });
   }
@@ -430,7 +441,6 @@ private Rect getCroppedRect(Size cameraPreviewSize, Rect visibleRect, int rotati
     return visibleRect;
   }
 
-
   @SuppressWarnings("SuspiciousNameCombination")
   private void rotateRect(Rect rect) {
     rect.set(rect.top, rect.left, rect.bottom, rect.right);
@@ -495,12 +505,12 @@ private abstract class PostInitializationTask<Result> extends SerialAsyncTask<Re
     }
   }
 
-  private class RotatePreviewAsyncTask extends AsyncTask<byte[], Void, byte[]> {
+  private class CaptureTask extends AsyncTask<byte[], Void, byte[]> {
     private final Size previewSize;
     private final int  rotation;
     private final Rect croppingRect;
 
-    public RotatePreviewAsyncTask(Size previewSize, int rotation, Rect croppingRect) {
+    public CaptureTask(Size previewSize, int rotation, Rect croppingRect) {
       this.previewSize  = previewSize;
       this.rotation     = rotation;
       this.croppingRect = croppingRect;
@@ -516,6 +526,7 @@ protected byte[] doInBackground(byte[]... params) {
                                          rotation,
                                          croppingRect);
       } catch (IOException e) {
+        Log.w(TAG, e);
         return null;
       }
     }
