tag:github.com,2008:https://github.com/wizardAsia/sourcegraph/releasesTags from sourcegraph2019-06-20T06:25:08Ztag:github.com,2008:Repository/192945367/v3.5.0-rc.32019-06-20T06:25:08Zv3.5.0-rc.3tag:github.com,2008:Repository/192945367/v3.5.0-rc.22019-06-19T23:57:19Zv3.5.0-rc.2tag:github.com,2008:Repository/192945367/v3.5.0-rc.12019-06-15T00:42:35Zv3.5.0-rc.1ggilmoretag:github.com,2008:Repository/192945367/v3.4.42019-06-13T19:29:20Zv3.4.4tag:github.com,2008:Repository/192945367/v3.4.32019-06-06T23:28:11Zv3.4.3tag:github.com,2008:Repository/192945367/v3.4.22019-05-27T15:14:14Zv3.4.2<p>web: Remove NoRepositoriesEnabledAlert and noRepositoriesEnabled flag (<a class="issue-link js-issue-link" href="https://github.com/sourcegraph/sourcegraph-public-snapshot/pull/4128">…</a></p>
<p><a class="issue-link js-issue-link" href="https://github.com/sourcegraph/sourcegraph-public-snapshot/pull/4128">…sourcegraph#4128</a>)</p>
<p>This <span class="issue-keyword tooltipped tooltipped-se">fixes</span> <a class="issue-link js-issue-link" href="https://github.com/sourcegraph/sourcegraph-public-snapshot/issues/4127">sourcegraph#4127</a> by</p>
<p>1. removing the `NoRepositoriesEnabledAlert`
<br />2. deprecating the `noRepositoriesEnabled` `SiteFlag` and always have it
<br /> be `false`
<br />3. removing every usage of the `noRepositoriesEnabled` `SiteFlag` in the
<br /> web app</p>mrnuggettag:github.com,2008:Repository/192945367/v3.4.12019-05-22T19:11:05Zv3.4.1: properly handle instances that have empty settings (#4157)<p>properly handle instances that have empty settings (<a class="issue-link js-issue-link" href="https://github.com/sourcegraph/sourcegraph-public-snapshot/pull/4157">sourcegraph#4157</a>)</p>
<p>In older (2.x) versions of Sourcegraph it was possible to save an empty string
<br />as your user/org/global settings. This lead to various issues including just
<br />completely breaking the settings page: <a href="https://github.com/sourcegraph/sourcegraph/issues/1645">https://github.com/sourcegraph/sourcegraph/issues/1645</a></p>
<p>We later fixed that issue and made it such that saving empty settings is
<br />forbidden, but it doesn't appear we ever corrected such invalid settings. In
<br />one customer environment we've encountered a user who is reporting their
<br />settings are empty so we should handle this.</p>
<p>This is a quick fix which is cheap for us to maintain, so I opted for this
<br />approach for now. The more correct (but also more complex) approach would be to
<br />write a migration which transforms any empty settings into non-empty ones. I
<br />don't think it is worth the time it would take right now.</p>tag:github.com,2008:Repository/192945367/v3.2.82019-05-22T18:24:16Zv3.2.8beyangtag:github.com,2008:Repository/192945367/v3.3.82019-05-21T00:39:25Zv3.3.8tag:github.com,2008:Repository/192945367/v3.2.72019-05-21T23:36:23Zv3.2.7: Fix small editor (#3811)<p>Fix small editor (<a class="issue-link js-issue-link" href="https://github.com/sourcegraph/sourcegraph-public-snapshot/pull/3811">sourcegraph#3811</a>)</p>
<p>* Fix small editor</p>
<p><span class="issue-keyword tooltipped tooltipped-se">Fixes</span> <a class="issue-link js-issue-link" href="https://github.com/sourcegraph/sourcegraph-public-snapshot/issues/3645">sourcegraph#3645</a></p>
<p>* Add CHANGELOG entry</p>felixfbecker