dont Override finalize() and remove deprecated code in dispose(..)

André Behrens (serious6) · André Behrens (serious6) · commit bbfa59daddf0 · 2015-05-15T14:39:33.000+02:00
- removed code of finalize method since it will provide no benefit to be
called
- removed deprecated code from dispose method since it will result in
possible errors
diff --git a/src/main/java/microsoft/exchange/webservices/data/notification/StreamingSubscriptionConnection.java b/src/main/java/microsoft/exchange/webservices/data/notification/StreamingSubscriptionConnection.java
@@ -243,8 +243,7 @@ public StreamingSubscriptionConnection(ExchangeService service,
       Iterable<StreamingSubscription> subscriptions, int lifetime)
       throws Exception {
     this(service, lifetime);
-    EwsUtilities.validateParamCollection(subscriptions.iterator(),
-        "subscriptions");
+    EwsUtilities.validateParamCollection(subscriptions.iterator(), "subscriptions");
     for (StreamingSubscription subscription : subscriptions) {
       this.subscriptions.put(subscription.getId(), subscription);
     }
@@ -527,33 +526,10 @@ private void issueNotificationEvents(GetStreamingEventsResponse gseResponse) {
     }
   }
 
-  /**
-   * Finalizes an instance of the StreamingSubscriptionConnection class.
-   */
-  @Override
-  protected void finalize() throws Throwable {
-    this.dispose(false);
-  }
-
   /**
    * Frees resources associated with this StreamingSubscriptionConnection.
    */
   public void dispose() {
-    this.dispose(true);
-  }
-
-  /**
-   * Performs application-defined tasks associated with freeing, releasing, or
-   * resetting unmanaged resources.
-   *
-   * @param suppressFinalizer Value indicating whether to suppress the garbage collector's
-   *                          finalizer.
-   */
-  private void dispose(boolean suppressFinalizer) {
-    if (suppressFinalizer) {
-      System.runFinalizersOnExit(false);
-    }
-
     synchronized (this) {
       if (!this.isDisposed) {
         if (this.currentHangingRequest != null) {
