PHPCS: whitelist some code for select sniffs

jrfnl · jrfnl · commit ef7cfe1722e8 · 2019-04-21T14:05:44.000+02:00
diff --git a/src/Core_Language_Command.php b/src/Core_Language_Command.php
@@ -311,7 +311,7 @@ public function uninstall( $args, $assoc_args ) {
 	 *
 	 * @subcommand update
 	 */
-	public function update( $args, $assoc_args ) {
+	public function update( $args, $assoc_args ) { // phpcs:ignore Generic.CodeAnalysis.UselessOverridingMethod.Found -- Overruling the documentation, so not useless ;-).
 		parent::update( $args, $assoc_args );
 	}
 
diff --git a/src/Plugin_Language_Command.php b/src/Plugin_Language_Command.php
@@ -466,6 +466,7 @@ public function update( $args, $assoc_args ) {
 	 * @return array
 	 */
 	private function get_all_plugins() {
+		// phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound -- Using WP native hook.
 		return apply_filters( 'all_plugins', get_plugins() );
 	}
 }
diff --git a/src/WP_CLI/LanguagePackUpgrader.php b/src/WP_CLI/LanguagePackUpgrader.php
@@ -57,8 +57,12 @@ public function download_package( $package ) {
 		 * @param bool          $reply   Whether to bail without returning the package. Default is false.
 		 * @param string        $package The package file name.
 		 * @param \WP_Upgrader  $this    The WP_Upgrader instance.
+		 *
+		 * @phpcs:disable WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound -- Using WP native hook.
 		 */
 		$reply = apply_filters( 'upgrader_pre_download', false, $package, $this );
+		// phpcs:enable
+
 		if ( false !== $reply ) {
 			return $reply;
 		}

Original file line number	Diff line number	Diff line change
`@@ -311,7 +311,7 @@ public function uninstall( $args, $assoc_args ) {`
`311`	`311`	`*`
`312`	`312`	`* @subcommand update`
`313`	`313`	`*/`
`314`		`- public function update( $args, $assoc_args ) {`
	`314`	`+ public function update( $args, $assoc_args ) { // phpcs:ignore Generic.CodeAnalysis.UselessOverridingMethod.Found -- Overruling the documentation, so not useless ;-).`
`315`	`315`	`parent::update( $args, $assoc_args );`
`316`	`316`	`}`
`317`	`317`
Original file line number	Diff line number	Diff line change
`@@ -466,6 +466,7 @@ public function update( $args, $assoc_args ) {`
`466`	`466`	`* @return array`
`467`	`467`	`*/`
`468`	`468`	`private function get_all_plugins() {`
	`469`	`+ // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound -- Using WP native hook.`
`469`	`470`	`return apply_filters( 'all_plugins', get_plugins() );`
`470`	`471`	`}`
`471`	`472`	`}`