fix(event_source): kinesis subsequenceNumber str type to int (aws-powertools#3275)

roger-zhangg · leandrodamascena · web-flow · commit b3c9ee0965d4 · 2023-10-31T12:16:02.000Z
Co-authored-by: Leandro Damascena &lt;lcdama@amazon.pt&gt;
diff --git a/aws_lambda_powertools/utilities/data_classes/kinesis_firehose_event.py b/aws_lambda_powertools/utilities/data_classes/kinesis_firehose_event.py
@@ -201,7 +201,7 @@ def sequence_number(self) -> str:
         return self._metadata["sequenceNumber"]
 
     @property
-    def subsequence_number(self) -> str:
+    def subsequence_number(self) -> int:
         """Kinesis stream sub-sequence number; present only when Kinesis Stream is source
 
         Note: this will only be present for Kinesis streams using record aggregation
diff --git a/aws_lambda_powertools/utilities/parser/models/kinesis_firehose.py b/aws_lambda_powertools/utilities/parser/models/kinesis_firehose.py
@@ -10,7 +10,7 @@ class KinesisFirehoseRecordMetadata(BaseModel):
     partitionKey: str
     approximateArrivalTimestamp: PositiveInt
     sequenceNumber: str
-    subsequenceNumber: str
+    subsequenceNumber: int
 
 
 class KinesisFirehoseRecord(BaseModel):
diff --git a/tests/events/kinesisFirehoseKinesisEvent.json b/tests/events/kinesisFirehoseKinesisEvent.json
@@ -13,7 +13,7 @@
                 "partitionKey": "4d1ad2b9-24f8-4b9d-a088-76e9947c317a",
                 "approximateArrivalTimestamp": 1664028820148,
                 "sequenceNumber": "49546986683135544286507457936321625675700192471156785154",
-                "subsequenceNumber": ""
+                "subsequenceNumber": 0
             }
         },
         {
@@ -25,7 +25,7 @@
                 "partitionKey": "4d1ad2b9-24f8-4b9d-a088-76e9947c318a",
                 "approximateArrivalTimestamp": 1664028793294,
                 "sequenceNumber": "49546986683135544286507457936321625675700192471156785155",
-                "subsequenceNumber": ""
+                "subsequenceNumber": 0
             }
         }
     ]
diff --git a/tests/unit/parser/test_kinesis_firehose.py b/tests/unit/parser/test_kinesis_firehose.py
@@ -62,7 +62,7 @@ def test_firehose_trigger_event_kinesis_no_envelope():
 
     metadata_01: KinesisFirehoseRecordMetadata = record_01.kinesisRecordMetadata
     assert metadata_01.partitionKey == "4d1ad2b9-24f8-4b9d-a088-76e9947c317a"
-    assert metadata_01.subsequenceNumber == ""
+    assert metadata_01.subsequenceNumber == 0
     assert metadata_01.shardId == "shardId-000000000000"
     assert metadata_01.approximateArrivalTimestamp == 1664028820148
     assert metadata_01.sequenceNumber == "49546986683135544286507457936321625675700192471156785154"
@@ -74,7 +74,7 @@ def test_firehose_trigger_event_kinesis_no_envelope():
 
     metadata_02: KinesisFirehoseRecordMetadata = record_02.kinesisRecordMetadata
     assert metadata_02.partitionKey == "4d1ad2b9-24f8-4b9d-a088-76e9947c318a"
-    assert metadata_02.subsequenceNumber == ""
+    assert metadata_02.subsequenceNumber == 0
     assert metadata_02.shardId == "shardId-000000000001"
     assert metadata_02.approximateArrivalTimestamp == 1664028793294
     assert metadata_02.sequenceNumber == "49546986683135544286507457936321625675700192471156785155"

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@`
`13`	`13`	`"partitionKey": "4d1ad2b9-24f8-4b9d-a088-76e9947c317a",`
`14`	`14`	`"approximateArrivalTimestamp": 1664028820148,`
`15`	`15`	`"sequenceNumber": "49546986683135544286507457936321625675700192471156785154",`
`16`		`- "subsequenceNumber": ""`
	`16`	`+ "subsequenceNumber": 0`
`17`	`17`	`}`
`18`	`18`	`},`
`19`	`19`	`{`
`@@ -25,7 +25,7 @@`
`25`	`25`	`"partitionKey": "4d1ad2b9-24f8-4b9d-a088-76e9947c318a",`
`26`	`26`	`"approximateArrivalTimestamp": 1664028793294,`
`27`	`27`	`"sequenceNumber": "49546986683135544286507457936321625675700192471156785155",`
`28`		`- "subsequenceNumber": ""`
	`28`	`+ "subsequenceNumber": 0`
`29`	`29`	`}`
`30`	`30`	`}`
`31`	`31`	`]`