Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: VOLTTRON/dnp3-python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: zagor/dnp3-python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 5 files changed
  • 2 contributors

Commits on Oct 20, 2023

  1. Unlock the GIL when destroying DNP3Manager.

    The ThreadPool owned by DNP3Manager causes a deadlock when it is destroyed without unlocking the GIL.
    By returning the DNP3Manager with a custom deleter which unlocks the GIL during destruction the pool can be deleted.
    Solution borrowed from: pybind/pybind11#1446
    Shawn Greenman authored and zagor committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    107e213 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3f3f8e3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6297c84 View commit details
    Browse the repository at this point in the history
Loading