Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: moby/moby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: zinic/docker
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 4 files changed
  • 1 contributor

Commits on May 22, 2014

  1. Proposed Refactorings for Client/Daemon Init 

    * Addition of a new method to the engine.Job struct (https://github.com/zinic/docker/blob/master/engine/job.go#L108-L110) to allow for sub-job scheduling without requiring visibility into the Job's Engine
* Relocation of daemon argument processing and startup to its own file /daemon/initjob.go (https://github.com/zinic/docker/blob/master/daemon/initjob.go) as an engine.Job
* Removal of daemon init related code from /docker/docker.go (https://github.com/zinic/docker/blob/master/docker/docker.go)
* Modification of argument processing in /docker/docker.go (https://github.com/zinic/docker/blob/master/docker/docker.go) to allow for a stepped transition to engine.Job for legacy client code
* Addition of the new daemon init job to /builtins/builtins.go (https://github.com/zinic/docker/blob/master/builtins/builtins.go)

Docker-DCO-1.1-Signed-off-by: John Hopper <[email protected]> (github: zinic)
    John Hopper committed May 22, 2014
    Configuration menu
    Copy the full SHA
    d91ddfa View commit details
    Browse the repository at this point in the history
Loading