Skip to content
This repository was archived by the owner on Feb 6, 2023. It is now read-only.

Commit 17b7d67

Browse files
authored
Fix release process (#3)
* Updated documentation. * Fixed release build script.
1 parent 56f1aeb commit 17b7d67

11 files changed

Lines changed: 92 additions & 56 deletions

File tree

Products/XcodeGitHub.app.zip

-22.9 KB
Binary file not shown.

Products/XcodeGitHub.framework.zip

-5.49 KB
Binary file not shown.

Products/xcode-github

-81.8 KB
Binary file not shown.

XcodeGitHub.xcodeproj/project.pbxproj

Lines changed: 15 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,6 @@
160160
4DDAA4D2216ABF40002F3F8E /* Headers */,
161161
4DDAA4D3216ABF40002F3F8E /* Sources */,
162162
4DDAA4D4216ABF40002F3F8E /* Frameworks */,
163-
4DF8729A219BA41A00EDCB98 /* Build Static Library */,
164163
);
165164
buildRules = (
166165
);
@@ -178,7 +177,7 @@
178177
isa = PBXProject;
179178
attributes = {
180179
CLASSPREFIX = XG;
181-
LastUpgradeCheck = 1000;
180+
LastUpgradeCheck = 1010;
182181
ORGANIZATIONNAME = Branch;
183182
TargetAttributes = {
184183
4DDAA4D5216ABF40002F3F8E = {
@@ -203,28 +202,6 @@
203202
};
204203
/* End PBXProject section */
205204

206-
/* Begin PBXShellScriptBuildPhase section */
207-
4DF8729A219BA41A00EDCB98 /* Build Static Library */ = {
208-
isa = PBXShellScriptBuildPhase;
209-
buildActionMask = 2147483647;
210-
files = (
211-
);
212-
inputFileListPaths = (
213-
);
214-
inputPaths = (
215-
"$(CONFIGURATION_BUILD_DIR)/libXcodeGitHub.a",
216-
);
217-
name = "Build Static Library";
218-
outputFileListPaths = (
219-
);
220-
outputPaths = (
221-
);
222-
runOnlyForDeploymentPostprocessing = 0;
223-
shellPath = /bin/bash;
224-
shellScript = "\"${SOURCE_ROOT}\"/\"${PRODUCT_NAME}\"/make-static-lib.sh\n";
225-
};
226-
/* End PBXShellScriptBuildPhase section */
227-
228205
/* Begin PBXSourcesBuildPhase section */
229206
4DDAA4D3216ABF40002F3F8E /* Sources */ = {
230207
isa = PBXSourcesBuildPhase;
@@ -278,8 +255,12 @@
278255
CLANG_WARN_UNGUARDED_AVAILABILITY = YES_AGGRESSIVE;
279256
CLANG_WARN_UNREACHABLE_CODE = YES;
280257
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
258+
CODE_SIGNING_ALLOWED = YES;
281259
CODE_SIGN_IDENTITY = "Mac Developer";
260+
CODE_SIGN_STYLE = Manual;
261+
COPY_PHASE_STRIP = NO;
282262
DEBUG_INFORMATION_FORMAT = dwarf;
263+
DEVELOPMENT_TEAM = WRWLR8VRUH;
283264
ENABLE_STRICT_OBJC_MSGSEND = YES;
284265
ENABLE_TESTABILITY = YES;
285266
GCC_C_LANGUAGE_STANDARD = gnu11;
@@ -297,12 +278,13 @@
297278
GCC_WARN_UNUSED_FUNCTION = YES;
298279
GCC_WARN_UNUSED_VARIABLE = YES;
299280
INFOPLIST_FILE = Info.plist;
300-
MACOSX_DEPLOYMENT_TARGET = 10.10;
281+
MACOSX_DEPLOYMENT_TARGET = 10.12;
301282
MTL_ENABLE_DEBUG_INFO = INCLUDE_SOURCE;
302283
MTL_FAST_MATH = YES;
303284
ONLY_ACTIVE_ARCH = YES;
304285
SDKROOT = macosx;
305286
SKIP_INSTALL = YES;
287+
STRIP_INSTALLED_PRODUCT = NO;
306288
};
307289
name = Debug;
308290
};
@@ -338,8 +320,12 @@
338320
CLANG_WARN_UNGUARDED_AVAILABILITY = YES_AGGRESSIVE;
339321
CLANG_WARN_UNREACHABLE_CODE = YES;
340322
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
341-
CODE_SIGN_IDENTITY = "Mac Developer";
342-
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
323+
CODE_SIGNING_ALLOWED = YES;
324+
CODE_SIGN_IDENTITY = "Developer ID Application";
325+
CODE_SIGN_STYLE = Manual;
326+
COPY_PHASE_STRIP = NO;
327+
DEBUG_INFORMATION_FORMAT = dwarf;
328+
DEVELOPMENT_TEAM = WRWLR8VRUH;
343329
ENABLE_NS_ASSERTIONS = NO;
344330
ENABLE_STRICT_OBJC_MSGSEND = YES;
345331
GCC_C_LANGUAGE_STANDARD = gnu11;
@@ -351,20 +337,19 @@
351337
GCC_WARN_UNUSED_FUNCTION = YES;
352338
GCC_WARN_UNUSED_VARIABLE = YES;
353339
INFOPLIST_FILE = Info.plist;
354-
MACOSX_DEPLOYMENT_TARGET = 10.10;
340+
MACOSX_DEPLOYMENT_TARGET = 10.12;
355341
MTL_ENABLE_DEBUG_INFO = NO;
356342
MTL_FAST_MATH = YES;
357343
SDKROOT = macosx;
358344
SKIP_INSTALL = YES;
345+
STRIP_INSTALLED_PRODUCT = NO;
359346
};
360347
name = Release;
361348
};
362349
4DDAA4E0216ABF40002F3F8E /* Debug */ = {
363350
isa = XCBuildConfiguration;
364351
buildSettings = {
365-
CODE_SIGN_STYLE = Automatic;
366352
CREATE_INFOPLIST_SECTION_IN_BINARY = YES;
367-
DEVELOPMENT_TEAM = R63EM248DP;
368353
EXECUTABLE_PREFIX = lib;
369354
PRODUCT_NAME = "$(TARGET_NAME)";
370355
};
@@ -373,9 +358,7 @@
373358
4DDAA4E1216ABF40002F3F8E /* Release */ = {
374359
isa = XCBuildConfiguration;
375360
buildSettings = {
376-
CODE_SIGN_STYLE = Automatic;
377361
CREATE_INFOPLIST_SECTION_IN_BINARY = YES;
378-
DEVELOPMENT_TEAM = R63EM248DP;
379362
EXECUTABLE_PREFIX = lib;
380363
PRODUCT_NAME = "$(TARGET_NAME)";
381364
};

XcodeGitHub.xcodeproj/xcshareddata/xcschemes/XcodeGitHub.xcscheme

Lines changed: 22 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,29 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<Scheme
3-
LastUpgradeVersion = "1000"
4-
version = "1.3">
3+
LastUpgradeVersion = "1010"
4+
version = "1.7">
55
<BuildAction
66
parallelizeBuildables = "YES"
77
buildImplicitDependencies = "YES">
8+
<PostActions>
9+
<ExecutionAction
10+
ActionType = "Xcode.IDEStandardExecutionActionsCore.ExecutionActionType.ShellScriptAction">
11+
<ActionContent
12+
title = "Run Script"
13+
scriptText = "#!/bin/bash&#10;&quot;${SOURCE_ROOT}&quot;/&quot;${PRODUCT_NAME}&quot;/make-static-lib.sh&#10;"
14+
shellToInvoke = "/bin/bash">
15+
<EnvironmentBuildable>
16+
<BuildableReference
17+
BuildableIdentifier = "primary"
18+
BlueprintIdentifier = "4DDAA4D5216ABF40002F3F8E"
19+
BuildableName = "libXcodeGitHub.a"
20+
BlueprintName = "XcodeGitHub"
21+
ReferencedContainer = "container:XcodeGitHub.xcodeproj">
22+
</BuildableReference>
23+
</EnvironmentBuildable>
24+
</ActionContent>
25+
</ExecutionAction>
26+
</PostActions>
827
<BuildActionEntries>
928
<BuildActionEntry
1029
buildForTesting = "YES"
@@ -33,7 +52,7 @@
3352
</AdditionalOptions>
3453
</TestAction>
3554
<LaunchAction
36-
buildConfiguration = "Debug"
55+
buildConfiguration = "Release"
3756
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
3857
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
3958
launchStyle = "0"

build-release

Lines changed: 31 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@ set -euo pipefail
44
marketing_version=1.0.3
55
build_version=1
66

7+
textBold="\e[1m\e[34m" # Dark Blue
8+
textNormal="\e[0m"
9+
710
function full_path_of_directory() {
811
local directory_name
912
directory_name="$1"
@@ -42,17 +45,33 @@ mkdir -p "$build_products_directory"
4245

4346
function build_project() {
4447
local project="$1"
48+
local executable="$2"
49+
printf "${textBold}>>> Building '$project'...${textNormal}\n" 1>&2
4550
update_version "$project"
4651
xcodebuild \
4752
-project "${project}".xcodeproj \
4853
-scheme "${project}" \
54+
-configuration Release \
4955
-quiet clean build \
5056
CONFIGURATION_BUILD_DIR="$build_products_directory"
57+
codesign -dv --verbose=4 "$build_products_directory"/"$executable"
58+
echo ""
59+
}
60+
61+
function compress_product() {
62+
local product="$build_products_directory"/"$1"
63+
ditto -c -k --sequesterRsrc --keepParent "$product" "$product".zip
64+
rm -rf "$product"
5165
}
5266

53-
build_project XcodeGitHub
54-
build_project xcode-github-cli
55-
build_project xcode-github-app
67+
build_project XcodeGitHub XcodeGitHub.framework/Versions/A/XcodeGitHub
68+
build_project xcode-github-cli xcode-github
69+
build_project xcode-github-app XcodeGitHub.app
70+
71+
compress_product xcode-github.dSYM
72+
compress_product XcodeGitHub.app
73+
compress_product XcodeGitHub.app.dSYM
74+
compress_product XcodeGitHub.framework
5675

5776
ditto -c -k --sequesterRsrc --keepParent \
5877
"$build_products_directory"/XcodeGitHub.app \
@@ -67,8 +86,15 @@ rm -rf "$build_products_directory"/XcodeGitHub.framework
6786
rm -Rf "$build_products_directory"/libXcodeGitHub.a
6887
rm -Rf "$build_products_directory"/usr
6988

70-
echo ">>> Build ${marketing_version}(${build_version}) products in 'Products':"
71-
ls -al Products
89+
printf "${textBold}>>> Build ${marketing_version}(${build_version}) products in 'Products':${textNormal}\n"
90+
ls -al "$build_products_directory"
91+
92+
if ! askYN "Release version ${marketing_version}?"
93+
then
94+
exit 1
95+
fi
96+
97+
rm -rf "$build_products_directory"
7298

7399
if ! askYN "Release version ${marketing_version}?"
74100
then

xcode-github-app.xcodeproj/project.pbxproj

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -237,12 +237,12 @@
237237
isa = PBXProject;
238238
attributes = {
239239
CLASSPREFIX = XGA;
240-
LastUpgradeCheck = 0930;
240+
LastUpgradeCheck = 1010;
241241
ORGANIZATIONNAME = Branch;
242242
TargetAttributes = {
243243
4D7661672057565200216B72 = {
244244
CreatedOnToolsVersion = 9.2;
245-
ProvisioningStyle = Automatic;
245+
ProvisioningStyle = Manual;
246246
SystemCapabilities = {
247247
com.apple.HardenedRuntime = {
248248
enabled = 1;
@@ -410,7 +410,7 @@
410410
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
411411
GCC_WARN_UNUSED_FUNCTION = YES;
412412
GCC_WARN_UNUSED_VARIABLE = YES;
413-
MACOSX_DEPLOYMENT_TARGET = 10.11;
413+
MACOSX_DEPLOYMENT_TARGET = 10.12;
414414
MTL_ENABLE_DEBUG_INFO = YES;
415415
ONLY_ACTIVE_ARCH = YES;
416416
SDKROOT = macosx;
@@ -462,7 +462,7 @@
462462
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
463463
GCC_WARN_UNUSED_FUNCTION = YES;
464464
GCC_WARN_UNUSED_VARIABLE = YES;
465-
MACOSX_DEPLOYMENT_TARGET = 10.11;
465+
MACOSX_DEPLOYMENT_TARGET = 10.12;
466466
MTL_ENABLE_DEBUG_INFO = NO;
467467
SDKROOT = macosx;
468468
VALID_ARCHS = x86_64;
@@ -474,6 +474,7 @@
474474
buildSettings = {
475475
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
476476
CODE_SIGN_ENTITLEMENTS = "xcode-github-app/xcode-github-app.entitlements";
477+
CODE_SIGN_STYLE = Manual;
477478
COMBINE_HIDPI_IMAGES = YES;
478479
DEVELOPMENT_TEAM = WRWLR8VRUH;
479480
ENABLE_HARDENED_RUNTIME = YES;
@@ -485,6 +486,7 @@
485486
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/../Frameworks";
486487
PRODUCT_BUNDLE_IDENTIFIER = "io.branch.xcode-github-app";
487488
PRODUCT_NAME = XcodeGitHub;
489+
PROVISIONING_PROFILE_SPECIFIER = "";
488490
};
489491
name = Debug;
490492
};
@@ -493,6 +495,8 @@
493495
buildSettings = {
494496
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
495497
CODE_SIGN_ENTITLEMENTS = "xcode-github-app/xcode-github-app.entitlements";
498+
CODE_SIGN_IDENTITY = "Developer ID Application";
499+
CODE_SIGN_STYLE = Manual;
496500
COMBINE_HIDPI_IMAGES = YES;
497501
DEVELOPMENT_TEAM = WRWLR8VRUH;
498502
ENABLE_HARDENED_RUNTIME = YES;
@@ -504,6 +508,7 @@
504508
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/../Frameworks";
505509
PRODUCT_BUNDLE_IDENTIFIER = "io.branch.xcode-github-app";
506510
PRODUCT_NAME = XcodeGitHub;
511+
PROVISIONING_PROFILE_SPECIFIER = "";
507512
};
508513
name = Release;
509514
};

xcode-github-app.xcodeproj/xcshareddata/xcschemes/xcode-github-app.xcscheme

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<Scheme
3-
LastUpgradeVersion = "0940"
3+
LastUpgradeVersion = "1010"
44
version = "1.3">
55
<BuildAction
66
parallelizeBuildables = "YES"

xcode-github-cli.xcodeproj/project.pbxproj

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -91,12 +91,12 @@
9191
4D744BFB2047A53B002CA796 /* Project object */ = {
9292
isa = PBXProject;
9393
attributes = {
94-
LastUpgradeCheck = 0930;
94+
LastUpgradeCheck = 1010;
9595
ORGANIZATIONNAME = Branch;
9696
TargetAttributes = {
9797
4D744C022047A53B002CA796 = {
9898
CreatedOnToolsVersion = 9.2;
99-
ProvisioningStyle = Automatic;
99+
ProvisioningStyle = Manual;
100100
};
101101
};
102102
};
@@ -179,7 +179,7 @@
179179
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
180180
GCC_WARN_UNUSED_FUNCTION = YES;
181181
GCC_WARN_UNUSED_VARIABLE = YES;
182-
MACOSX_DEPLOYMENT_TARGET = 10.10;
182+
MACOSX_DEPLOYMENT_TARGET = 10.12;
183183
MTL_ENABLE_DEBUG_INFO = YES;
184184
ONLY_ACTIVE_ARCH = YES;
185185
SDKROOT = macosx;
@@ -217,7 +217,7 @@
217217
CLANG_WARN_UNGUARDED_AVAILABILITY = YES_AGGRESSIVE;
218218
CLANG_WARN_UNREACHABLE_CODE = YES;
219219
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
220-
CODE_SIGN_IDENTITY = "Mac Developer";
220+
CODE_SIGN_IDENTITY = "Developer ID Application";
221221
COPY_PHASE_STRIP = NO;
222222
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
223223
ENABLE_NS_ASSERTIONS = NO;
@@ -230,7 +230,7 @@
230230
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
231231
GCC_WARN_UNUSED_FUNCTION = YES;
232232
GCC_WARN_UNUSED_VARIABLE = YES;
233-
MACOSX_DEPLOYMENT_TARGET = 10.10;
233+
MACOSX_DEPLOYMENT_TARGET = 10.12;
234234
MTL_ENABLE_DEBUG_INFO = NO;
235235
SDKROOT = macosx;
236236
};
@@ -239,7 +239,7 @@
239239
4D744C0B2047A53B002CA796 /* Debug */ = {
240240
isa = XCBuildConfiguration;
241241
buildSettings = {
242-
CODE_SIGN_STYLE = Automatic;
242+
CODE_SIGN_STYLE = Manual;
243243
CREATE_INFOPLIST_SECTION_IN_BINARY = YES;
244244
DEVELOPMENT_TEAM = WRWLR8VRUH;
245245
FRAMEWORK_SEARCH_PATHS = (
@@ -251,16 +251,18 @@
251251
"$(inherited)",
252252
"$(PROJECT_DIR)/Products",
253253
);
254-
MACOSX_DEPLOYMENT_TARGET = 10.10;
254+
MACOSX_DEPLOYMENT_TARGET = 10.12;
255255
PRODUCT_BUNDLE_IDENTIFIER = "io.branch.xcode-github.command";
256256
PRODUCT_NAME = "$(TARGET_NAME)";
257+
PROVISIONING_PROFILE_SPECIFIER = "";
257258
};
258259
name = Debug;
259260
};
260261
4D744C0C2047A53B002CA796 /* Release */ = {
261262
isa = XCBuildConfiguration;
262263
buildSettings = {
263-
CODE_SIGN_STYLE = Automatic;
264+
CODE_SIGN_IDENTITY = "Developer ID Application";
265+
CODE_SIGN_STYLE = Manual;
264266
CREATE_INFOPLIST_SECTION_IN_BINARY = YES;
265267
DEVELOPMENT_TEAM = WRWLR8VRUH;
266268
FRAMEWORK_SEARCH_PATHS = (
@@ -272,9 +274,10 @@
272274
"$(inherited)",
273275
"$(PROJECT_DIR)/Products",
274276
);
275-
MACOSX_DEPLOYMENT_TARGET = 10.10;
277+
MACOSX_DEPLOYMENT_TARGET = 10.12;
276278
PRODUCT_BUNDLE_IDENTIFIER = "io.branch.xcode-github.command";
277279
PRODUCT_NAME = "$(TARGET_NAME)";
280+
PROVISIONING_PROFILE_SPECIFIER = "";
278281
};
279282
name = Release;
280283
};

xcode-github-cli.xcodeproj/xcshareddata/xcschemes/xcode-github-cli.xcscheme

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<Scheme
3-
LastUpgradeVersion = "0930"
3+
LastUpgradeVersion = "1010"
44
version = "1.3">
55
<BuildAction
66
parallelizeBuildables = "YES"

0 commit comments

Comments
 (0)