[Bug 16795][emscripten] Correctly get drawing canvas from DOM element

peter-b · peter-b · commit d6f1155cf7b3 · 2016-02-04T14:58:35.000Z
We were using the HTML Canvas API incorrectly, which was causing exceptions to be thrown by browsers with conformant implementations. See: * https://bugzilla.mozilla.org/show_bug.cgi?id=1244480 * whatwg/html#595
diff --git a/engine/src/em-surface.js b/engine/src/em-surface.js
@@ -26,7 +26,7 @@ mergeInto(LibraryManager.library, {
         var canvas = Module['canvas'];
 
         // Create and get a 2D rendering context for the canvas
-        var context = canvas.getContext('2d', false);
+        var context = canvas.getContext('2d');
         if (!context) {
             context = Browser.createContext(canvas, false, true);
         }

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ mergeInto(LibraryManager.library, {`
`26`	`26`	`var canvas = Module['canvas'];`
`27`	`27`
`28`	`28`	`// Create and get a 2D rendering context for the canvas`
`29`		`- var context = canvas.getContext('2d', false);`
	`29`	`+ var context = canvas.getContext('2d');`
`30`	`30`	`if (!context) {`
`31`	`31`	`context = Browser.createContext(canvas, false, true);`
`32`	`32`	`}`