SONARPY-789 S5953: Avoid raising on names prefixed with underscore

andreaguarino · guillaume-dequenne · commit cb6e0c59e2b4 · 2020-08-27T11:15:16.000+02:00
diff --git a/python-checks/src/main/java/org/sonar/python/checks/UndefinedSymbolsCheck.java b/python-checks/src/main/java/org/sonar/python/checks/UndefinedSymbolsCheck.java
@@ -71,7 +71,7 @@ private static class UnresolvedSymbolsVisitor extends BaseTreeVisitor {
 
     @Override
     public void visitName(Name name) {
-      if (name.isVariable() && name.symbol() == null) {
+      if (name.isVariable() && name.symbol() == null && !name.name().startsWith("_")) {
         nameIssues.computeIfAbsent(name.name(), k -> new ArrayList<>()).add(name);
       }
     }
diff --git a/python-checks/src/test/resources/checks/undefinedSymbols/undefinedSymbols.py b/python-checks/src/test/resources/checks/undefinedSymbols/undefinedSymbols.py
@@ -102,3 +102,6 @@ def use_glob3():
 
 global GLOB3
 print(GLOB3) # FN
+
+_some_implicit_global_vars # ok we exclude variables starting with `_`
+__some_implicit_global_vars__ # ok

Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ private static class UnresolvedSymbolsVisitor extends BaseTreeVisitor {`
`71`	`71`
`72`	`72`	`@Override`
`73`	`73`	`public void visitName(Name name) {`
`74`		`- if (name.isVariable() && name.symbol() == null) {`
	`74`	`+ if (name.isVariable() && name.symbol() == null && !name.name().startsWith("_")) {`
`75`	`75`	`nameIssues.computeIfAbsent(name.name(), k -> new ArrayList<>()).add(name);`
`76`	`76`	`}`
`77`	`77`	`}`