Cleanup Code

Glavo · Glavo · commit f0ecbb274a7b · 2025-04-04T22:03:46.000+08:00
diff --git a/src/main/java/org/glavo/viewer/file/types/classfile/ParsedViewerPane.java b/src/main/java/org/glavo/viewer/file/types/classfile/ParsedViewerPane.java
@@ -48,7 +48,7 @@
  */
 public class ParsedViewerPane extends BorderPane {
 
-    private Viewer viewer;
+    private final Viewer viewer;
 
     private final TreeView<FileComponent> tree;
     private final SearchBar searchBar;
diff --git a/src/main/java/org/glavo/viewer/file/types/classfile/SearchBar.java b/src/main/java/org/glavo/viewer/file/types/classfile/SearchBar.java
@@ -151,9 +151,7 @@ public String toString() {
         }
     }
 
-    private static final Pattern textFill = Pattern.compile("-fx-text-fill:[^;]*;");
-
-    private ParsedViewerPane pane;
+    private final ParsedViewerPane pane;
 
     private ListIterator<ClassFileComponent> iterator = null;
     private ClassFileComponent selected = null;
@@ -257,15 +255,4 @@ public void search(ActionEvent event) {
         this.iterator = ans.listIterator();
     }
 
-    public void setColor(String color) {
-        String style = textField.getStyle() == null ? "" : textField.getStyle();
-        Matcher m = textFill.matcher(style);
-        if (!m.find()) {
-            style += "-fx-text-fill: " + color + ";";
-        } else {
-            style = m.replaceAll("-fx-text-fill: " + color + ";");
-        }
-        textField.setStyle(style);
-    }
-
 }

Original file line number	Diff line number	Diff line change
`@@ -151,9 +151,7 @@ public String toString() {`
`151`	`151`	`}`
`152`	`152`	`}`
`153`	`153`
`154`		`- private static final Pattern textFill = Pattern.compile("-fx-text-fill:[^;]*;");`
`155`		`-`
`156`		`- private ParsedViewerPane pane;`
	`154`	`+ private final ParsedViewerPane pane;`
`157`	`155`
`158`	`156`	`private ListIterator<ClassFileComponent> iterator = null;`
`159`	`157`	`private ClassFileComponent selected = null;`
`@@ -257,15 +255,4 @@ public void search(ActionEvent event) {`
`257`	`255`	`this.iterator = ans.listIterator();`
`258`	`256`	`}`
`259`	`257`
`260`		`- public void setColor(String color) {`
`261`		`- String style = textField.getStyle() == null ? "" : textField.getStyle();`
`262`		`- Matcher m = textFill.matcher(style);`
`263`		`- if (!m.find()) {`
`264`		`- style += "-fx-text-fill: " + color + ";";`
`265`		`- } else {`
`266`		`- style = m.replaceAll("-fx-text-fill: " + color + ";");`
`267`		`- }`
`268`		`- textField.setStyle(style);`
`269`		`- }`
`270`		`-`
`271`	`258`	`}`