mm: fix wrong comments about anon_vma lock

Yuanhan Liu · torvalds · commit 631b0cfdbd80 · 2013-02-05T20:38:48.000+11:00
We use rwsem since commit 5a50508 ("mm/rmap: Convert the struct anon_vma::mutex to an rwsem"). And most of comments are converted to the new rwsem lock; while just 2 more missed from: $ git grep 'anon_vma->mutex' Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com> Acked-by: Ingo Molnar <mingo@kernel.org> Cc: Mel Gorman <mel@csn.ul.ie> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
diff --git a/include/linux/mmu_notifier.h b/include/linux/mmu_notifier.h
@@ -151,7 +151,7 @@ struct mmu_notifier_ops {
  * Therefore notifier chains can only be traversed when either
  *
  * 1. mmap_sem is held.
- * 2. One of the reverse map locks is held (i_mmap_mutex or anon_vma->mutex).
+ * 2. One of the reverse map locks is held (i_mmap_mutex or anon_vma->rwsem).
  * 3. No other concurrent thread can access the list (release)
  */
 struct mmu_notifier {
diff --git a/mm/mmap.c b/mm/mmap.c
@@ -2943,7 +2943,7 @@ static void vm_lock_mapping(struct mm_struct *mm, struct address_space *mapping)
  * vma in this mm is backed by the same anon_vma or address_space.
  *
  * We can take all the locks in random order because the VM code
- * taking i_mmap_mutex or anon_vma->mutex outside the mmap_sem never
+ * taking i_mmap_mutex or anon_vma->rwsem outside the mmap_sem never
  * takes more than one of them in a row. Secondly we're protected
  * against a concurrent mm_take_all_locks() by the mm_all_locks_mutex.
  *

Original file line number	Diff line number	Diff line change
`@@ -151,7 +151,7 @@ struct mmu_notifier_ops {`
`151`	`151`	`* Therefore notifier chains can only be traversed when either`
`152`	`152`	`*`
`153`	`153`	`* 1. mmap_sem is held.`
`154`		`- * 2. One of the reverse map locks is held (i_mmap_mutex or anon_vma->mutex).`
	`154`	`+ * 2. One of the reverse map locks is held (i_mmap_mutex or anon_vma->rwsem).`
`155`	`155`	`* 3. No other concurrent thread can access the list (release)`
`156`	`156`	`*/`
`157`	`157`	`struct mmu_notifier {`
Original file line number	Diff line number	Diff line change
`@@ -2943,7 +2943,7 @@ static void vm_lock_mapping(struct mm_struct mm, struct address_space mapping)`
`2943`	`2943`	`* vma in this mm is backed by the same anon_vma or address_space.`
`2944`	`2944`	`*`
`2945`	`2945`	`* We can take all the locks in random order because the VM code`
`2946`		`- * taking i_mmap_mutex or anon_vma->mutex outside the mmap_sem never`
	`2946`	`+ * taking i_mmap_mutex or anon_vma->rwsem outside the mmap_sem never`
`2947`	`2947`	`* takes more than one of them in a row. Secondly we're protected`
`2948`	`2948`	`* against a concurrent mm_take_all_locks() by the mm_all_locks_mutex.`
`2949`	`2949`	`*`