JCF: DUNE-DAQ/daqdataformats#79: replace daqdataformats::TriggerRecor…#488
Draft
jcfreeman2 wants to merge 1 commit intodevelopfrom
Draft
JCF: DUNE-DAQ/daqdataformats#79: replace daqdataformats::TriggerRecor…#488jcfreeman2 wants to merge 1 commit intodevelopfrom
jcfreeman2 wants to merge 1 commit intodevelopfrom
Conversation
…dHeader::operator[] with daqdataformats::TriggerRecordHeader::at, which performs the identical function and hasn't been removed from the code
13 tasks
Contributor
Author
|
Closing this as I'm reconsidering the removal of |
Contributor
Author
|
Reopening (although still in Draft form) in light of daqdataformats commit 45a02b2c8748 in DUNE-DAQ/daqdataformats#81 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…dHeader::operator[] with daqdataformats::TriggerRecordHeader::at, which performs the identical function and hasn't been removed from the code
Description
In
TRBModulea call todaqdataformats::ComponentRequest::operator[]is replaced with a call todaqdataformats::ComponentRequest::atas the former has been removed for reasons described in DUNE-DAQ/daqdataformats#81. Noteatdoes exactly the same thingoperator[]did.To test the changes, make sure the code still builds, and confirm for yourself by looking at
daqdataformats::ComponentRequest::atthat it does the same thingdaqdataformats::ComponentRequest::operator[]did.Type of change
I suppose this is an optimization in the sense that
dfmoduleswon't build unless this is merged once DUNE-DAQ/daqdataformats#81 is merged intodaqdataformats.Testing checklist
dbt-build --unittest)pytest -s minimal_system_quick_test.py)dunedaq_integtest_bundle.sh)python -m pytest)pre-commit run --all-files)Comments here on the testing
Further checks
dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)(Indicate issue here: # (issue))