Skip to content

SequentialCommandGroup is incompatible with other command groups #253

@AbhijayS

Description

@AbhijayS

Behavior
This command causes ArrayOutOfBounds Exception when passed into ParallelRaceGroup.
This command does not work as intended when passed as a deadline into a ParallelDeadlineGroup.
And other issues...

Why?
When end() is called, it sets the internal index to -1. This means isFinished() method will return false even though the command has already ended. Worse yet, if end() -> isFinished() -> end() is called, it causes an ArrayOutOfBounds Exception due to the index being -1.
https://github.com/FTCLib/FTCLib/blob/1c8995d09413b406e0f4aff238ea4edc2bb860c4/core/src/main/java/com/arcrobotics/ftclib/command/SequentialCommandGroup.java#L87C36-L87C36

Is this the desired behavior or am I missing something?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions