[[ Bug 15836 ]] Only send OnOpen/OnClose for initial open / final close.

livecodeian · livecodeian · commit 501e8d9dbf2f · 2015-09-01T11:49:53.000+01:00
diff --git a/docs/notes/bugfix-15836.md b/docs/notes/bugfix-15836.md
@@ -0,0 +1 @@
+# Widgets: OnOpen / OnClosed messages sent when widget is relayered.
diff --git a/engine/src/widget.cpp b/engine/src/widget.cpp
@@ -161,14 +161,16 @@ bool MCWidget::visit_self(MCObjectVisitor* p_visitor)
 void MCWidget::open(void)
 {
 	MCControl::open();
-    if (m_widget != nil)
-        MCwidgeteventmanager->event_open(this);
+	// IM-2015-09-01: [[ Bug 15836 ]] Only send widget event when transitioning from 0 -> 1
+	if (opened == 1 && m_widget != nil)
+		MCwidgeteventmanager->event_open(this);
 }
 
 void MCWidget::close(void)
 {
-    if (m_widget != nil)
-        MCwidgeteventmanager->event_close(this);
+	// IM-2015-09-01: [[ Bug 15836 ]] Only send widget event when transitioning from 1 -> 0
+	if (opened == 1 && m_widget != nil)
+		MCwidgeteventmanager->event_close(this);
 	MCControl::close();
 }
 

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+# Widgets: OnOpen / OnClosed messages sent when widget is relayered.`
Original file line number	Diff line number	Diff line change
`@@ -161,14 +161,16 @@ bool MCWidget::visit_self(MCObjectVisitor* p_visitor)`
`161`	`161`	`void MCWidget::open(void)`
`162`	`162`	`{`
`163`	`163`	`MCControl::open();`
`164`		`- if (m_widget != nil)`
`165`		`- MCwidgeteventmanager->event_open(this);`
	`164`	`+ // IM-2015-09-01: [[ Bug 15836 ]] Only send widget event when transitioning from 0 -> 1`
	`165`	`+ if (opened == 1 && m_widget != nil)`
	`166`	`+ MCwidgeteventmanager->event_open(this);`
`166`	`167`	`}`
`167`	`168`
`168`	`169`	`void MCWidget::close(void)`
`169`	`170`	`{`
`170`		`- if (m_widget != nil)`
`171`		`- MCwidgeteventmanager->event_close(this);`
	`171`	`+ // IM-2015-09-01: [[ Bug 15836 ]] Only send widget event when transitioning from 1 -> 0`
	`172`	`+ if (opened == 1 && m_widget != nil)`
	`173`	`+ MCwidgeteventmanager->event_close(this);`
`172`	`174`	`MCControl::close();`
`173`	`175`	`}`
`174`	`176`