[Bug 16539][emscripten] Implement "the systemVersion"

peter-b · peter-b · commit 015a20787d71 · 2016-01-06T19:57:36.000Z
Make `the systemVersion` empty on HTML5.
diff --git a/docs/dictionary/function/systemVersion.lcdoc b/docs/dictionary/function/systemVersion.lcdoc
@@ -10,7 +10,7 @@ Summary: <return|Returns> the version number of the operating system.
 
 Introduced: 1.0
 
-OS: mac,windows,linux,ios,android
+OS: mac,windows,linux,ios,android,html5
 
 Platforms: desktop,server,web,mobile
 
@@ -52,4 +52,6 @@ Android 2.3.1 installed, this property will return 2.3.1.
 
 >*Note:* When running a Mac OS application in the Classic box on an OS X system, the <systemVersion> function returns the version number of the Classic system folder.
 
+On HTML5 the <systemVersion> is empty.
+
 References: string (keyword), function (control_st), environment (function), buildNumber (function), libURLVersion (function), QTVersion (function), return (glossary)
diff --git a/docs/notes/bugfix-16539.md b/docs/notes/bugfix-16539.md
@@ -0,0 +1 @@
+# Implement "the systemVersion" in HTML5 standalones.
diff --git a/engine/src/em-system.cpp b/engine/src/em-system.cpp
@@ -168,8 +168,7 @@ MCEmscriptenSystem::GetCurrentTime()
 bool
 MCEmscriptenSystem::GetVersion(MCStringRef & r_string)
 {
-	MCEmscriptenNotImplemented();
-	return false;
+	return MCStringCopy(kMCEmptyString, r_string);
 }
 
 bool
diff --git a/tests/lcs/core/engine/engine.livecodescript b/tests/lcs/core/engine/engine.livecodescript
@@ -191,11 +191,11 @@ end TestSysError
 
 
 on TestSystemVersion
-if the platform is "HTML5" then
-TestSkip "systemVersion not empty", "bug 16539"
-exit TestSystemVersion
-end if
-TestAssert "the systemVersion is not empty", the systemVersion is not empty
+   if the platform is "HTML5" then
+      TestAssert "the systemVersion is empty", the systemVersion is empty
+   else
+      TestAssert "the systemVersion is not empty", the systemVersion is not empty
+   end if
 end TestSystemVersion
 
 

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+# Implement "the systemVersion" in HTML5 standalones.`
Original file line number	Diff line number	Diff line change
`@@ -168,8 +168,7 @@ MCEmscriptenSystem::GetCurrentTime()`
`168`	`168`	`bool`
`169`	`169`	`MCEmscriptenSystem::GetVersion(MCStringRef & r_string)`
`170`	`170`	`{`
`171`		`- MCEmscriptenNotImplemented();`
`172`		`- return false;`
	`171`	`+ return MCStringCopy(kMCEmptyString, r_string);`
`173`	`172`	`}`
`174`	`173`
`175`	`174`	`bool`