[22054] Ensure mobilePickPhoto() proceeds after taking a photo

livecodepanos · livecodepanos · commit ed4a2b360a9e · 2020-03-31T14:09:46.000+03:00
On some Samsung devices, mobilePickPhoto() did not proceed after taking a photo
using the device camera. This happened because the temp file where the
photo would be stored until the user accepts it could not be created due to
insufficient permissions. This patch ensures the appropriate permissions are
set so as mobilePickPhoto() works as expected on all Android devices.
diff --git a/docs/notes/bugfix-22054.md b/docs/notes/bugfix-22054.md
@@ -0,0 +1 @@
+# Ensure mobilePickPhoto() proceeds after taking a photo on Samsung phones
diff --git a/engine/src/java/com/runrev/android/Engine.java b/engine/src/java/com/runrev/android/Engine.java
@@ -2146,7 +2146,7 @@ public void showCamera()
 		String t_path = m_temp_image_file.getPath();
 
 		Uri t_uri;
-		t_uri = FileProvider.getProvider(getContext()).addPath(t_path, t_path, "image/jpeg", true, ParcelFileDescriptor.MODE_WRITE_ONLY);
+		t_uri = FileProvider.getProvider(getContext()).addPath(t_path, t_path, "image/jpeg", true, ParcelFileDescriptor.MODE_READ_WRITE);
 
 		Intent t_image_capture = new Intent(MediaStore.ACTION_IMAGE_CAPTURE);
 		t_image_capture.putExtra(MediaStore.EXTRA_OUTPUT, t_uri);

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+# Ensure mobilePickPhoto() proceeds after taking a photo on Samsung phones`