Skip to content
This repository was archived by the owner on Feb 15, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nikhilm/qhttpserver
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: Mendeley/qhttpserver
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 20 commits
  • 23 files changed
  • 8 contributors

Commits on Nov 28, 2011

  1. * Fixed the Doxyfile to not use absolute paths

     * Updated the link to http-parser
    hamstah committed Nov 28, 2011
    Configuration menu
    Copy the full SHA
    2144999 View commit details
    Browse the repository at this point in the history
  2. Cleanup

     * Replaced signals/slots by Q_SIGNALS/Q_SLOTS
     * Added bool returns for write function so they don't silently fail
     * Added Q_UNUSED for some unused parameters in QHttpConnection
    hamstah committed Nov 28, 2011
    Configuration menu
    Copy the full SHA
    ab91734 View commit details
    Browse the repository at this point in the history
  3. Updated code to latest http-parser

    Removed the version of http-parser that was included here as it was outdated.
    Added instructions in README.md to get the latest http-parser version
    Fixed the code to follow http-parser changes (nodejs/http-parser@53adfac)
    hamstah committed Nov 28, 2011
    Configuration menu
    Copy the full SHA
    2069b0c View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2011

  1. Cleanup

    Modified the status codes to not be global and defined in the server
    Fixed the missing url extraction
    hamstah committed Nov 30, 2011
    Configuration menu
    Copy the full SHA
    7d930a4 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2011

  1. Configuration menu
    Copy the full SHA
    bc498f0 View commit details
    Browse the repository at this point in the history
  2. Fixed memory leaks

    Added some sanity checks
    hamstah committed Dec 1, 2011
    Configuration menu
    Copy the full SHA
    b1e3e18 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2011

  1. Added path in Qt includes

    hamstah committed Dec 2, 2011
    Configuration menu
    Copy the full SHA
    0a80552 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    89edbe8 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2011

  1. Add CMake build system.

    robertknight committed Dec 8, 2011
    Configuration menu
    Copy the full SHA
    a28fa21 View commit details
    Browse the repository at this point in the history
  2. Fix parsing of path and query string from URLs

    The URL passed to QHttpConnection::Url includes the path and the query string, use
    QUrl to parse this into components instead of using the whole string as the path.
    robertknight committed Dec 8, 2011
    Configuration menu
    Copy the full SHA
    4eee024 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2011

  1. Fixes compilation on release mode.

    Carles Pina committed Dec 14, 2011
    Configuration menu
    Copy the full SHA
    da26725 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2012

  1. Prevent QHttpRequest / QHttpResponse objects from being destroyed if …

    …the associated TCP connection is disconnected.
    
    The documentation for QHttpServer states QHttpRequest objects are never deleted by QHttpServer and that
    the QHttpResponse is only deleted when end() is called.
    
    This is not the case however if the TCP connection is disconnected before the reply has been delivered -
    since the QHttpRequest and QHttpResponse objects are owned by the QHttpConnection that creates them and
    QHttpConnection is deleted if the TCP connection is disconnected.  This can happen if the server
    'parks' the QHttpRequest/QHttpResponse objects whilst waiting for data from another source before
    sending back the reply - in our case, user input.
    
    This commit adds a ref count to QHttpConnection to track the count of active users (QHttpRequest or
    QHttpResponse objects).
    
    The QHttpConnection is released when there are no active users AND the TCP connection is disconnected.
    
    With this change, the onus is on the user of QHttpServer to handle all requests, otherwise they will
    be leaked.  Previously they would have been 'leaked' only until the connection was closed.
    Robert Knight committed Mar 6, 2012
    Configuration menu
    Copy the full SHA
    caec4d3 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2012

  1. Revert "Prevent QHttpRequest / QHttpResponse objects from being destr…

    …oyed if the associated TCP connection is disconnected."
    
    This change caused two additional problems:
    
      * Any request/response objects not explicitly deleted are never freed which is a hassle for downstream
        consumers to have to deal with.
    
      * In addition to keeping the QHttpConnection alive, consumers also have to make sure they release
        any requests/responses before the QHttpServer is destroyed - since QHttpServer releases all connections
        when destroyed.
    
    Instead, a simpler approach is to avoid holding on to dangling references downstream (eg. by using a QWeakPointer
    or not holding on to a reference to QHttpRequest/QHttpResponse which could outlive the connection).
    
    This commit instead keeps the old behavior but fixes the QHttpServer documentation about memory management.
    
    This reverts commit caec4d3.
    Robert Knight committed Mar 16, 2012
    Configuration menu
    Copy the full SHA
    d405828 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2013

  1. Add QHttpServer::errorString() method

    This returns the error from the underlying QTcpServer in the event of
    a listen() failure.
    
    MD-19113
    Robert Knight committed Jan 10, 2013
    Configuration menu
    Copy the full SHA
    d5b9ab3 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2014

  1. Configuration menu
    Copy the full SHA
    06eadb2 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1 from gvaf/master

    Added serverPort() method returning the listening port of the server
    cpina committed Jan 24, 2014
    Configuration menu
    Copy the full SHA
    b4af034 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2014

  1. Support building with Qt 5 if USE_QT5 is enabled

    MD-19537
    Robert Knight committed Mar 21, 2014
    Configuration menu
    Copy the full SHA
    5685335 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2015

  1. Remove Mendeley specific build file

    This file never worked outside of a source tree that looked at least
    very similar to the Mendeley tree.
    Sascha Cunz committed Sep 3, 2015
    Configuration menu
    Copy the full SHA
    6ffe656 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2017

  1. Change {to,from}Ascii to {to,from}Latin1

    Cunz, Sascha (ELS-LON) committed Nov 10, 2017
    Configuration menu
    Copy the full SHA
    80bfdbf View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2 from scunz/ascii_latin1

    Change {to,from}Ascii to {to,from}Latin1
    cpina authored Nov 10, 2017
    Configuration menu
    Copy the full SHA
    fc2598f View commit details
    Browse the repository at this point in the history
Loading