Skip to content

StreamingWebSocketClient never close #998

@CorrM

Description

@CorrM

In StreamingWebSocketClient.CloseDisposeAndClearRequestsAsync

CancellationTokenSource tokenSource = null;
            try
            {
                if (_clientWebSocket != null && (_clientWebSocket.State == WebSocketState.Open || _clientWebSocket.State == WebSocketState.Connecting))
                {
                    tokenSource = new CancellationTokenSource(ConnectionTimeout);

                    await _clientWebSocket.CloseOutputAsync(WebSocketCloseStatus.NormalClosure, "",
                         tokenSource.Token).ConfigureAwait(false);
                    while (_clientWebSocket.State != WebSocketState.Closed && !tokenSource.IsCancellationRequested) ;
                }
            }
            catch { }
            finally
            {
                tokenSource?.Dispose();
            }

This while is CPU eater, use Task.Delay.
The websocket never closed for some reason. (thats make that while go crazy on the CPU)

Expected Behavior

Websocket closed and my CPU are safe

Current Behavior

While loop eat the CPU because websocket state never be Closed (WebSocketState.Closed)

Possible Solution

  1. Look for what case the websocket state not updated.
  2. Add Task.Delay for 1.0 or 0.5 sec even if the close problem fixed.

Steps to Reproduce

  1. call StreamingWebSocketClient.StartAsync()
  2. call StreamingWebSocketClient.Dispose() or StreamingWebSocketClient.StopAsync()

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions