Skip to content

Commit 7213407

Browse files
committed
[[ Bug 14645 ]] Check for errors in MCField::formattabalignments
[[ Bug 14645 ]] Fix stack name in styledtext test file
1 parent 7287f07 commit 7213407

2 files changed

Lines changed: 10 additions & 9 deletions

File tree

engine/src/field.cpp

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1550,26 +1550,27 @@ bool MCField::formattabalignments(const intenum_t *p_alignments, uindex_t p_alig
15501550
switch (p_alignments[i])
15511551
{
15521552
case kMCParagraphTextAlignLeft:
1553-
/* UNCHECKED */ MCListAppendCString(*t_list, "left");
1553+
if (!MCListAppendCString(*t_list, "left"))
1554+
return false;
15541555
break;
15551556

15561557
case kMCParagraphTextAlignRight:
1557-
/* UNCHECKED */ MCListAppendCString(*t_list, "right");
1558+
if (!MCListAppendCString(*t_list, "right"))
1559+
return false;
15581560
break;
15591561

15601562
case kMCParagraphTextAlignCenter:
1561-
/* UNCHECKED */ MCListAppendCString(*t_list, "center");
1563+
if (!MCListAppendCString(*t_list, "center"))
1564+
return false;
15621565
break;
15631566

15641567
case kMCParagraphTextAlignJustify:
1565-
/* UNCHECKED */ MCListAppendCString(*t_list, "justify");
1568+
if (!MCListAppendCString(*t_list, "justify"))
1569+
return false;
15661570
break;
15671571

15681572
default:
1569-
{
1570-
MCAssert(false);
1571-
return false;
1572-
}
1573+
MCUnreachableReturn(false);
15731574
}
15741575
}
15751576

tests/lcs/core/field/styledText.livecodescript

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
script "CoreFieldHtmlText"
1+
script "CoreFieldStyledText"
22
/*
33
Copyright (C) 2016 LiveCode Ltd.
44

0 commit comments

Comments
 (0)